Coder Social home page Coder Social logo

Comments (16)

Byron avatar Byron commented on July 23, 2024

A great move ! This will definitely give it (even) more velocity !
Thank you for taking care !

from serde.

frewsxcv avatar frewsxcv commented on July 23, 2024

This can be closed, right?

from serde.

erickt avatar erickt commented on July 23, 2024

Yep!

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

do you want serde (de-)serializer-repos in that orga or do you prefer the devs to put them in their own repos?

from serde.

erickt avatar erickt commented on July 23, 2024

@oli-obk: I'd be happy to have them in serde.rs. Want one for xml? What would you like it called?

@Byron: want one for yaml?

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

Just xml? Since it'll already be inside the serde-rs orga it doesn't need any annotations like rust or serde.

from serde.

Byron avatar Byron commented on July 23, 2024

@erickt Sorry for the late reply. It seems there is a repo for yaml already. Right now I don't know how you see the separation to be done,but I guess I can just look at the json implementation once it is there. In the meanwhile, I will keep working in my fork and communicate through the PR, until there is something usable.

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

@Byron: the xml-deserialization is already working as its own repo. Maybe that'll help set it up for yaml.

from serde.

Byron avatar Byron commented on July 23, 2024

@oli-obk Thank you, I will do that ! I'd still have a lot of questions about how collaboration is supposed to work. Maybe a guide exists somewhere and I didn't find it. For reasons of lazyness, I'd just push to serde-rs/yaml directly, without setting up a PR to allow code-reviews. The latter, however, would be good to have, and I would love to get other eyes on the code at least once certain milestones are met. While writing this, I changed my mind and now believe a PR based workflow would be the way to go ... so let's do it that way :).

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

technically we should set up homu to get the r+ abilities

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

i am still pushing directly, as it's so early in development, but if you think reviews are better, I can start doing PRs

from serde.

Byron avatar Byron commented on July 23, 2024

I am not sure who will have time for reviews anyway, however, I just want to get used to that workflow, and if in doubt, will just merge my own PRs.

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

we can do mutual reviewing. Not sure how I can set github up to get notifications about PRs though

from serde.

frewsxcv avatar frewsxcv commented on July 23, 2024

Could just get added as members (not necessarily owners) to a team in the organization and whenever a review needs to happen, just ping the team

from serde.

Byron avatar Byron commented on July 23, 2024

I agree, this could just work using the @ syntax to reach out to individuals.

from serde.

oli-obk avatar oli-obk commented on July 23, 2024

I put myself on the "watch" thingy next to "fork" and "star" for yaml, maybe it'll work :)

from serde.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.