Coder Social home page Coder Social logo

Comments (4)

allebb avatar allebb commented on May 29, 2024

Good find! - I'll investigate... Probably time to take this out now that
the theme no longer uses tables to display of the module icons ;) - I'll
sort this out over the weekend! - If you can, assign this bug to me!!

On 22 October 2014 21:15, Nigel Caldwell [email protected] wrote:

fifth option down in Sentora config is Icons per Row.

This no longer works with the new Bootstrap theme.


Reply to this email directly or view it on GitHub
#75.

from sentora-core.

jasondavis avatar jasondavis commented on May 29, 2024

If memory serves me correct, I didn't use this option when I built the BS theme, probably good idea to either add in support or else remove the option

from sentora-core.

allebb avatar allebb commented on May 29, 2024

Yeah its no problem Jason :) - I think removal is probably the best bet to be honest, will stop people being tempted to use HTML tables for layout ;)

...I'll be working on a few of these 'issues' that I have assigned to me today and tomorrow so this should be closed shortly :)

from sentora-core.

allebb avatar allebb commented on May 29, 2024

After reviewing the changes and assessing the impact on existing themes out there, I've decided to simply change the system setting type to ensure that it is no longer visible to the user in the Configuration module (in affect deprecating the feature) but leaving the current value of '10' set in the database whilst theme developers are notified of the change on our mailing list (to ensure they can fix up their themes before the next release).

This change however is a SQL change only and therefore has been pushed over to the installers repository here: sentora/sentora-installers@ff8f321

At present the only obvious change is that the option is no longer available from the Sentora Config module (no longer user editable), in the next release we'll remove the setting entirely from the database.

Tested and is working fine in my development environment.

from sentora-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.