Not working with Electron 5? about electron-extensions

[sentialx]

Could you write steps to reproduce?

[IceHacks]

Yes sorry. I'll edit my post.

[sentialx]

Please, show me your full code of the extension loading part. Do you execute it in app load event?

[IceHacks]

@sentialx I put it in the "ready" event. Which is (from what I read) where it goes.

...
const createWindow = async () => {
	var extension = new EE.ExtensibleSession(session.defaultSession);
	await extension.loadExtension(
		"path"
	);
	// Create the browser window.
	mainWindow = new BrowserWindow({
		width: 800,
		height: 600
	});

	mainWindow.loadURL("path");

	mainWindow.webContents.openDevTools();

	mainWindow.on("closed", () => {
		mainWindow = null;
	});
};
app.on("ready", createWindow);
...

[sentialx]

What isn't working in webRequest?

[IceHacks]

The background.js should block the loading of a file and replace it (using chrome.tabs.executeScript).

here is a sample:

"use strict";

chrome.webRequest.onBeforeRequest.addListener(
	function (details) {
		if (details.url.includes("something")) {
			inject();
			return { cancel: true };
		}
	},
	{
		urls: chrome.runtime.getManifest()["externally_connectable"].matches
	},
	["blocking"]
);

all the APIs should be supported

[IceHacks]

Wait a second. The thing that isn't working is not the blocking but another feature I am using. One sec. (I'll edit this)

I noticed that it was blocking the blocked files, but not redirecting the redirected ones.

EDIT:
It appears to be this part of the WebRequest on before request listener that isn't functioning:

...
if (redirect) {
	return {
		redirectUrl: chrome.runtime.getURL(fileName)
	};
}
...

Also, the blocking is working but the inject (using executeScript) is not.

[IceHacks]

Any discoveries?

[sentialx]

@IceHacks Not yet. I will need to test it out.

[IceHacks]

ok @sentialx if you need any more resources from me I should be able to get them.

[sentialx]

@IceHacks Could you create a repo to reproduce this (with manifest.json and all needed things to get it to run)?

[IceHacks]

I'll see what I can do @sentialx

[IceHacks]

@sentialx https://github.com/IceHacks/example-of-brokeness Just do npm i && npm start, the extension should not work. Then load the extension in chrome, it should work.

[IceHacks]

Don't know if you saw this 😄 just for good measure. I know you are busy.

[sentialx]

I saw, thanks

[sentialx]

@IceHacks Is it fixed?

[IceHacks]

No, but I found my own solution. It was probably just me doing something wrong.