Coder Social home page Coder Social logo

Comments (3)

pvdlg avatar pvdlg commented on May 24, 2024 1

I made the change in #152 but frankly keeping the custom port or not is really an arbitrary choice.
You should rely on a ssh URL to generate the https link in your release note.
I recommend to either use a https URL for repositoryUrl or to set the host options.

from release-notes-generator.

pvdlg avatar pvdlg commented on May 24, 2024 1

SSH and HTTPS are never going to have the same port number, regardless of what remote git provider is being used.

Yes but just using the default https port is not guaranteed to be correct. If you set a ssh URL we basically try to guess what is the corresponding https URL.

If the repositoryURL is artificially set to HTTPS (not matching the git clone URL) then wouldn't that cause conflicts in the other @semantic-release plugins which rely on that option?

It depends on your particular setup. That's why I also suggested to use the host option.

from release-notes-generator.

amclin avatar amclin commented on May 24, 2024

SSH and HTTPS are never going to have the same port number, regardless of what remote git provider is being used.

If the repositoryURL is artificially set to HTTPS (not matching the git clone URL) then wouldn't that cause conflicts in the other @semantic-release plugins which rely on that option?

from release-notes-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.