Wrong links in release-notes about release-notes-generator

[pvdlg]

This is defined by the commit property passed to the conventional-changelog context.

By default conventional-changelog set it to commits but we set it in our default to commit for GitLab.

This value can also be set via this plugin commit option.

I guess you must have something somewhere that set that value to dev instead and override both defaults.

[efuturetoday]

Hello pvdlg,

thank you for your fast response. That is a good catch for me - now I know which property controls the commit links. The strange thing is I do not modify the semantic-release context in any way and just using the official plugins for it. Side note: The @semantic-release/changelogplugin does indeed generate a correct changelog where the links to the commits are correct.

[pvdlg]

@semantic-release/changelog doesn't generate any changelog it just write the text generated by semantic-release/release-notes-generator into a file.

The changelog text we add to the GitLab release and the one we write in CHANGELOG.md is strictly the same. If you see a difference between those two it means GitLAb change it on its side.

[efuturetoday]

@pvdlg it does make sense for me that the semantic-release/release-notes-generator does generate the changelog and the other plugins just consumes it. I will do a little test on my side and see if the @semantic-release/gitlab does send the right markdown to the gitlab backend. But I guess it will be fine. dev is the default branch for my repository. So it's possible, that Gitlab does process the markdown in any way and modify it. I will report the results here. Thank you for pointing this out!

[efuturetoday]

You can close this issue. It is obsolete. Gitlab receives the correct changelog and modifies it. I will investigate further on Gitlab. Thank you for your time and fast response!

[arkadioz]

Hi @pvdlg @efuturetoday I have this same issue but with bitbucket, my commits links in the release notes and changelog look like:

https://bitbucket.org/my-workspace/my-repo/commit/commitnumber

but it should be:

https://bitbucket.org/my-workspace/my-repo/commits/commitnumber

notice it should have s in commits, I notice here it is well configured

release-notes-generator/lib/hosts-config.js

Line 12 in c4963f5

commit: 'commits',

but why is my config not applying it? Am I missing something like maybe setting it up in releaserc.json file? Let me know if you need to see my .releaserc.json file or anything, thanks

SOLVED: conventional-changelog/conventional-changelog-config-spec#90 (comment)