Coder Social home page Coder Social logo

Comments (5)

Seldaek avatar Seldaek commented on July 18, 2024

It's not a bad idea, but I'm not sure if that would work very well, because then it keeps a reference to the object, which means it won't be destructed until the very end, and that means if it has any dependencies to be able to send the logs, it might just fail. I'd feel more comfortable adding that only to the buffer handler and not to the abstract one.

from monolog.

Shreef avatar Shreef commented on July 18, 2024

@Seldaek
Ok, makes sense

from monolog.

stof avatar stof commented on July 18, 2024

I would also register the close method directly instead of the magic function

from monolog.

Shreef avatar Shreef commented on July 18, 2024

Cool. I hope you can implement the solution and close the issue. if you need me to send a pull request or something, just let me know.

from monolog.

Seldaek avatar Seldaek commented on July 18, 2024

@Shreef if you don't mind sending a PR, that'd be great.

from monolog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.