Logger->addRecord() broken for locales using , as decimal digit separator about monolog

[hanneskod]

Here is a quick fix:

*** Monolog/Logger.php  2012-03-13 13:27:21.343220815 +0100
--- local/Logger.php    2012-03-13 12:29:59.531228485 +0100
***************
*** 162,174 ****
          if (!$this->handlers) {
              $this->pushHandler(new StreamHandler('php://stderr', self::DEBUG));
          }
          $record = array(
              'message' => (string) $message,
              'context' => $context,
              'level' => $level,
              'level_name' => self::getLevelName($level),
              'channel' => $this->name,
!             'datetime' => \DateTime::createFromFormat('U.u', sprintf('%.6f', microtime(true))),
              'extra' => array(),
          );
          // check if any message will handle this message
--- 162,179 ----
          if (!$this->handlers) {
              $this->pushHandler(new StreamHandler('php://stderr', self::DEBUG));
          }
+         
+         // Replace , with . in time to support locales using , as decimal digit separator
+         $time = sprintf('%.6f', microtime(true));
+         $time = str_replace(',', '.', $time);
+         
          $record = array(
              'message' => (string) $message,
              'context' => $context,
              'level' => $level,
              'level_name' => self::getLevelName($level),
              'channel' => $this->name,
!             'datetime' => \DateTime::createFromFormat('U.u', $time),
              'extra' => array(),
          );
          // check if any message will handle this message

[Seldaek]

Thanks for reporting and for the proposed fix, I'll take a look later this week hopefully, crazy busy right now no time to look in detail.

[Seldaek]

I wasn't able to reproduce unfortunately, but I think the fix I pushed is correct nonetheless. Please check and confirm.

[hanneskod]

Fix is confirmed. I guess the locale in question have to be installed in your OS to reproduce this behavoir...

A really nice fix I must say though. For someone like myself, not comming from the world of C, the sprintf function often seams like magic. This time all that was needed was a 10 sec. look at the documentation. So it goes!

[Seldaek]

Ok cool!