Comments (5)
I don't see any immediate issues with it but I don't like registering stuff with the default handler especially in an opaque and non-reversible way.
No surprises.
from stats.
Why is this required/needed?
I'd be against this as a default, /metrics is somewhat generic (e.g. we use it in the metrics.segment.com service).
If it must, maybe as a more explicit import in a subpackage - import _ "..../promethues/handler"
(though at that point you might as well call http.Handle
yourself as well).
from stats.
/metrics
is the standard endpoint for prometheus.
This change would be for convenience, if you have to import another package to replace one line of code it seems like it's not really worth it :P
from stats.
Also just thinking that if an external service were to be using this, this would implicitly expose /metrics
externally? That doesn't seem like the best idea.
from stats.
Alright you convinced me, that's a bad idea 😛
Thanks for your input guys!
from stats.
Related Issues (20)
- statsd decrement counter
- Update segmentio/taskstats dependecy in go.mod
- "github.com/segmentio/stats/v4" missing? HOT 2
- Can this library be used with telegraf?
- Support Datadog Distribution metric type ? HOT 3
- Update README with versioned Installation?
- Stats prefixed by dot when sending to datadog
- Prometheus stats are incompatible with the prometheus sdk HOT 2
- procstats kills process? HOT 4
- pushgateway support HOT 1
- Proposal for a new design HOT 10
- Allow for tags to be map[string]string HOT 1
- procstats fails to compile on OS X 10.11.6 HOT 2
- Panic HOT 3
- httpstats client + httpcache + go-github HOT 5
- Add GoString for Value
- Ambiguity in README.md HOT 3
- Per request tags HOT 1
- datadog/client.NewClientWith swallows errors HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stats.