Coder Social home page Coder Social logo

Comments (10)

ejcx avatar ejcx commented on June 10, 2024 1

Oh my mistake I completely misread your comment. Separate KMS key per service is very aggressive.

Is this supposed to be an additional safety mechanism besides using SSM IAM policy? Is there a particular issue with using only one KMS key?

from chamber.

ejcx avatar ejcx commented on June 10, 2024

@robinjoseph08 can you just set the environment variable in your profile? Seems like overkill to change the program when there is a simple fix available.

from chamber.

robinjoseph08 avatar robinjoseph08 commented on June 10, 2024

While that would work if we had one key with a different alias name, since we'll be having separate keys, it's a different alias for each service so we can't put it in our global profile.

from chamber.

robinjoseph08 avatar robinjoseph08 commented on June 10, 2024

Right, it's more of an additional safety mechanism. We didn't see that there was any reason for a particular service to have the ability to decrypt the secrets of any other service (even though we're already limiting which ones it can get through SSM). It just seemed like an unnecessarily large scope for a service's permission.

from chamber.

robinjoseph08 avatar robinjoseph08 commented on June 10, 2024

Any additional thoughts on this? I'd love to submit a PR, but only if you guys think it makes sense?

Having separate KMS keys is a pretty hard requirement for us, and we really want to make it as easy as possible to write secrets (i.e. as few environment variables necessary as possible).

from chamber.

FernandoMiguel avatar FernandoMiguel commented on June 10, 2024

this can be easily done via iam policies, and parameter prefix.
doing it at KMS level is overkill in my opinion
i posted an example in #45 (comment)

from chamber.

eriksw avatar eriksw commented on June 10, 2024

On the flipside of this, I'd appreciate a way to not use a customer-managed key at all, and instead just use the default AWS-managed key. There's relatively few reasons to use customer-managed keys if you grant kms:Decrypt permissions sparingly: i.e. with a condition on the PARAMETER_ARN encryption context key.

from chamber.

jdub avatar jdub commented on June 10, 2024

@eriksw You can use CHAMBER_KMS_KEY_ALIAS=aws/ssm chamber …. I'd even suggest that would be the better default.

from chamber.

stale avatar stale commented on June 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from chamber.

nickatsegment avatar nickatsegment commented on June 10, 2024

Out of scope I'd say.

from chamber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.