Use time.Time to represent timestamps in data structures about analytics-go

[calvinfo]

Strong +1

On Wed, Apr 20, 2016 at 3:59 PM, Achille [email protected] wrote:

@f2prateek https://github.com/f2prateek
@calvinfo https://github.com/calvinfo

Currently the timestamp and sentAt fields have a string type in the data
structures (Alias, Track, ...), this is not very handy and developers
have to refer to the HTTP API documentation to understand what format this
should be in (which isn't linked from the Go code).

I feel like we should use time.Time for these fields and take care of the
serialization internally so we take the burden off of the developers using
the library and leverage the compiler to verify that they're using valid
values (basically a time value, right now they could inject whatever string
format in there).

Let me know what you think about it?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#56

[f2prateek]

Yup agree, time.Time is better (we do this in java, android too) and we don't even need any magic for serialization because the default format is iso 8601.

[achille-roussel]

Yep, although the Go serializer uses nanosecond precision while the JS serializer uses milliseconds, any change this is gonna be an issue server side?

[calvinfo]

Should be good, as long as it serializes to an ISO timestamp. Node just
drops the extra precision.

On Wed, Apr 20, 2016 at 4:07 PM, Achille [email protected] wrote:

Yep, although the Go serializer uses nanosecond precision while the JS
serializer uses milliseconds, any change this is gonna be an issue server
side?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#56 (comment)