Comments (4)
Strong +1
On Wed, Apr 20, 2016 at 3:59 PM, Achille [email protected] wrote:
@f2prateek https://github.com/f2prateek
@calvinfo https://github.com/calvinfoCurrently the timestamp and sentAt fields have a string type in the data
structures (Alias, Track, ...), this is not very handy and developers
have to refer to the HTTP API documentation to understand what format this
should be in (which isn't linked from the Go code).I feel like we should use time.Time for these fields and take care of the
serialization internally so we take the burden off of the developers using
the library and leverage the compiler to verify that they're using valid
values (basically a time value, right now they could inject whatever string
format in there).Let me know what you think about it?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#56
from analytics-go.
Yup agree, time.Time
is better (we do this in java, android too) and we don't even need any magic for serialization because the default format is iso 8601.
from analytics-go.
Yep, although the Go serializer uses nanosecond precision while the JS serializer uses milliseconds, any change this is gonna be an issue server side?
from analytics-go.
Should be good, as long as it serializes to an ISO timestamp. Node just
drops the extra precision.
On Wed, Apr 20, 2016 at 4:07 PM, Achille [email protected] wrote:
Yep, although the Go serializer uses nanosecond precision while the JS
serializer uses milliseconds, any change this is gonna be an issue server
side?—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#56 (comment)
from analytics-go.
Related Issues (20)
- The Version variable is out of date HOT 1
- Event tracking: passing a pointer to `Enqueue` results in silent dropped events HOT 1
- Need source field in Context struct to keep track of who sent the Identify or Track payload. HOT 1
- Any way to check if all messages sent before calling client.Close()? HOT 13
- Feature question - any go middleware? GIN specific middleware? HOT 2
- master is not current version HOT 4
- No error returned on empty or invalid write-key HOT 1
- Unclear if client.Close() actually sends the queued messages
- ScreenInfo.Density has wrong type
- Go mod incompatibility HOT 8
- Missing Context.Direct HOT 2
- update config to support custom http client or http.RoundTripper HOT 1
- Release new version?
- Response body not always fully read HOT 1
- Readme has malformed command
- v3.2.1 not loadable thru gopkg.in HOT 4
- Typo in Product struct? HOT 1
- Add context in Callback HOT 2
- Will this library work with Google AppEngine? HOT 1
- Timestamp with not enough precision
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics-go.