Coder Social home page Coder Social logo

Comments (2)

lukpueh avatar lukpueh commented on August 16, 2024 1

likely all Signers could have more ergonomic signer-specific (or use-case-specific) constructors

Yes, a usable CryptoSigner.__init__ would already go a long way. Currently, CryptoSigner is abstract and all its subclasses are protected, which makes it unusable outside of from_priv_key_uri. If I could create a CryptoSigner from a pyca/cryptography private key object, then it would be easy for an application to create their own from_pem, e.g.:

from cryptography.hazmat.primitives.serialization import load_pem_private_key

private_key = load_pem_private_key(data, password)
signer = CryptoSigner(private_key)  # generate default public Key, if not passed explicitly

from securesystemslib.

jku avatar jku commented on August 16, 2024

I see no problems with this.

  • from_priv_key_uri() is generic but clumsy
  • likely all Signers could have more ergonomic signer-specific (or use-case-specific) constructors

I've never had a use-case where I wanted to avoid generic signer loading to have the latter but I can see others might.
Let's not add code "just because" but if an application use case gets easier by adding a constructor, let's do that.

from securesystemslib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.