Comments (4)
The pull request does not seem to solve the issue.
from node-wd-sync.
What are the problems you are still experiencing?
We've been using the fix for a couple of days now. I'm assuming that the Mocha tests are written using the wrap function as demonstrated in the samples.
from node-wd-sync.
Yes the fix works when using wrap but the initial post scope was wider, am wondering if the fix should be moved at the sync level.
from node-wd-sync.
No the problem is sync
and mocha done
callback integration, I don't see a generic way to do it at sync
level, the recommended solution is to use wrap, it will hide the done concept totally, and with @zah PR, the exception handling should now work properly.
from node-wd-sync.
Related Issues (20)
- .sleep throws an error - uses undefined `Fiber` variable HOT 1
- Whether wd-sync supports slow instance..? HOT 24
- Doc needs refresh.
- waitForElementByCss timeout value is ignored HOT 1
- Revisit/improve error handling. HOT 1
- Sync vs. Async? HOT 4
- sessionid in chrome undefined HOT 2
- @getElementsByXXX HOT 2
- Bug when I use phantomjs (ghostdriver) with node-wd-sync 1.2.4 HOT 1
- I can't load my Selenium tests after a wd-sync upgrade to the latest version HOT 3
- clickElement appears to be broken
- Docs refer to paths not in distribution
- Can't use returned element as argument to .execute HOT 2
- Cannot use TouchActions()
- How to implement click and wait
- execute javascript HOT 1
- @elementsByXXX do not return elements HOT 5
- How do we trap SE errors? HOT 4
- Crashes on Windows 7 (even with 1-wd-simple.js) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-wd-sync.