Include variables written to caller's scope about fluid

[sebastienros]

I will look into some examples/tests from shopify, but it looks like a bad behavior to me. All this variables should be local to the template, and not leak on subsequent renderings. But we need proof.

[sebastienros]

I can't find anything related in the tests https://github.com/Shopify/liquid/blob/9c72ccb82f4e7a1f158b59741596a473c499875e/test/integration/tags/include_tag_test.rb

It looks like the template shouldn't change the parent's variables, but that's it. From the documentation, the other values are actually defining the main context variables, so what you are seeing seems expected. We would need to check on a shopify site probably.

[jeremycook]

I'm with you on it "seems expected" but also "looks like bad behavior". It makes for all sorts of unfortunate problems that basically require me to Nil out variables before calling another include.

If it is by design according to Shopify may I suggest we make up our own tag like partial that has the scoped behavior you and I seem to expect.

[jeremycook]

Jekyll's implementation of include appears to align with what we expect, at least that's my impression after reading this: https://hamishwillee.github.io/2014/11/13/jekyll-includes-are-functions/