Comments (27)
Yep migration done and everything works smooth,
I just need time to make more tests, test again in my linux VM and pray that it will work on all OS X versions.
The biggest part of the upgrade is on components and widgets' headers the rest is find/replace + good cast. @Coirt I will push on saturday I think. I was the good occasion to clean some dead code too :)
from bidoo.
No. For exemple on baR
struct BARWidget : ModuleWidget {
BARWidget(BAR *module) : ModuleWidget(module) {
setPanel(SVG::load(assetPlugin(plugin, "res/BAR.svg")));
addChild(Widget::create<ScrewSilver>(Vec(RACK_GRID_WIDTH, 0)));
addChild(Widget::create<ScrewSilver>(Vec(box.size.x - 2 * RACK_GRID_WIDTH, 0)));
addChild(Widget::create<ScrewSilver>(Vec(RACK_GRID_WIDTH, RACK_GRID_HEIGHT - RACK_GRID_WIDTH)));
addChild(Widget::create<ScrewSilver>(Vec(box.size.x - 2 * RACK_GRID_WIDTH, RACK_GRID_HEIGHT - RACK_GRID_WIDTH)));
BARDisplay *display = new BARDisplay();
display->module = module;
display->box.pos = Vec(12.0f, 40.0f);
display->box.size = Vec(110.0f, 70.0f);
addChild(display);
from bidoo.
There is a template for the migration with the best practices, take this one as reference.
from bidoo.
make dep
before make
from bidoo.
Hello cschol, thanks for your proposal. I am currently facing issues with my last plugin on Linux but I think I will manage to resolve it asap. Once that being done I will start the upgrading process and if at some point I am stuck I will ask you or to the RPRT :)
Do you know what is the eta for 0.6 ?
from bidoo.
Perfect. Let us know. The release date is currently still being decided. Andrew is considering pushing it out a couple of weeks to get the (new) Plugin Manager up and running for v0.6
.
from bidoo.
I'd be happy to help also Sebastien don't hesitate to ask. I changed a few things on my fork in Bar and your .cpp/.hpp that are compatible with 0.6.0dev.
Did a trial run earlier, Forked a single module project and built against 0.6.0dev. Will be moving onto 0.6dev myself try get ahead of it!
21st March I think was decided on Release.
from bidoo.
Thanks for your proposal but it is almost done :)
I will look to your fork but to save time what did you changed in baR ? Is there a bug ? A missing feature ? An issue on params calibration ?
from bidoo.
Actually built earlier and got a lot of errors. Some were typos. But others are depreciated errors that changing doesn't seem to fix. Getting errors in the components too think its because of BidooComponents.hpp most errors were in there.
randomf
changed to randomUniform
clampi
clamp
rescalef
rescale
(not in fork)
Some other changes harder to explain but put some comments in the fork.
from bidoo.
Those are deprecation WARNINGS, not errors. Read the API Update Thread on how to make those new calls, for example clamp
, non-ambigous. You mostly need to add suffixes to your constants (or cast correctly) to clearly identify the data types.
from bidoo.
setPanel(SVG::load(assetPlugin(plugin, "res/Panel.svg")));
instead of
box.size = Vec(x, y);
{
SVGPanel *panel = new SVGPanel();
panel->box.size = box.size;
panel->setBackground(SVG::load(assetPlugin(plugin, "res/Panel.svg")));
addChild(panel);
}
is also so much nicer now.
from bidoo.
yep this upgrade is quite nice and as usual Andrew's code is very clean and readable, template help too and community is great :)
from bidoo.
i'll test too as soon as you pushed.
from bidoo.
Thought it was panel->setBackground(SVG::load(assetPlugin(plugin"SLUG", "res/Panel.svg")));
No?
Seemed to work in the other module I forked. Ahornberg-Microtonal.
from bidoo.
@Coirt i just copied the example above from fundamental/mutes, so i don't think so
from bidoo.
Was looking at luckyxxl found in Repair thread.
from bidoo.
luckyxxl hasn't changed the setpanel thing afaics.
it's not a necessary change for 0.6 compliance.
from bidoo.
It builds for 0.6.0dev though no errors might be another way to do it, idk. That other one I forked did crash when added for the first time though. Also crashes when duped (ctrl+d) Lucky's does not though weirdness. Will try it that way, didn't see that template cheers.
from bidoo.
Hey, when this change sneaked in?:
setPanel(SVG::load(assetPlugin(plugin, "res/MyModule.svg")));
from bidoo.
i think together with the other helper changes for 0.6.
edit: in template since https://github.com/VCVRack/Template/commit/f4bcd719e7a43ca28420cee8005e5b9a98a273c2
from bidoo.
0.6.0dev just pushed. works fine on windows. tell me if you have any issue on other platforms.
from bidoo.
nearly fine... couple svg missing/not loading
chute and ouaive panel
bidooLongSlider
from bidoo.
capital letters in the filenames don't match...
i.e. ChUTE vs CHUTE
from bidoo.
other than that:
building/loading fine on all platforms
running fine on linux and win
good job :)
from bidoo.
Get an build error:
src/ANTN.cpp:6:10: fatal error: mpg123.h: No such file or directory
#include <mpg123.h>
from bidoo.
That does it!
from bidoo.
Excellent work. Thanks everybody! Closing this issue.
from bidoo.
Related Issues (20)
- Feature request Zou Mai Run button and bipolar CV HOT 4
- zou mai quantiser issue HOT 5
- Feature request Zou Mai HOT 4
- Issue with bidoo modules saving samples in cardinal. HOT 3
- zOù MAï pattern step size CV not 10/8 but 10/7 HOT 5
- BORDL: Seg fault when loading module in 2.0.16 HOT 4
- bordL crashing Rack when attempting to insert it from the module browser into the rack on Windows HOT 3
- Zou Mai and reset and first 5 or so beats HOT 17
- Tag v2.0.17 HOT 2
- Emile 2.0.18 crashes Rack 2 2.1.2 (MacOS 12.4) on module delete HOT 6
- Strange .gitmodules file in the repository HOT 2
- rabBIT Ctrl-R HOT 3
- Build failure on macOS platform HOT 4
- After last update, Zou Mai triggers not responding to mouse click HOT 5
- Encore triggers 7 and 8 on track 2 will not program; lights work but no sound
- Suggestions for preset control and copy scene function! HOT 5
- Graphical glitch when zooming in on sample using cANARd sampler HOT 3
- build fail with Rack 2.2 HOT 9
- Feature Request: Copy/Paste funcitonality for pages in Zou Mai/Encore sequencers HOT 4
- Emile crashing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bidoo.