Coder Social home page Coder Social logo

Comments (3)

josegonzalez avatar josegonzalez commented on August 25, 2024

Make the PR. If it works and passes tests, why wouldn't it be merged?

from fuzzywuzzy.

dchaplinsky avatar dchaplinsky commented on August 25, 2024

Mostly because of two reasons:

  1. Memoization is not always a desirable behavior. If you have different data to compare each time, it would cost you memory to memoize results you won't be using anyway.
  2. I applied my ideas only to one method and did that barbarically using microoptimisations here and there (for example, I eliminated call to ratio and pasted appropriate chunk of code directly to the method and that gave me like another 1.5x speedup). If you have an idea how to generalize that to other methods without doing copy-paste spaghetti style coding — I'm happy to.

Maybe I'll come up with some ideas myself, just need some time to think it over and fresh brain.

from fuzzywuzzy.

josegonzalez avatar josegonzalez commented on August 25, 2024

Make memoization optional, off by default. Or provide alternative functions that are memoized.

If you can get a few of them working, even by copy-paste, we can try working through them to get it in decent shape :)

Closing for now since it's not actionable, but please feel free to open a pull request.

from fuzzywuzzy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.