Comments (4)
Hi @davidpadbury -- apologies for the inconvenience The plugin originally copied everything (even .svn files), then it only copied JS files, then started copying everything (minus some default excludes).
Background: The current rationale for the default is that many JavaScript will try to pull in relative-pathed resources via AJAX, so anything under the $jsSrcDir
is copied by default. I'm pretty sure that the operation to move everything is using [FileUtils.copyDirectory](http://commons.apache.org/io/apidocs/org/apache/commons/io/FileUtils.html#copyDirectory(java.io.File,%20java.io.File,%20java.io.FileFilter), which has a sort of clunky API for excluding/filtering.
I like the default where it is, but I think you're right, that an option to filter to only whatever the srcIncludes do (which is */.js by default) makes sense. It's just not trivial because the API being used to copy the directories can't read a normal collection of include/exclude strings.
As a workaround, have you considered limiting your JavaScript to a directory and pointing your $jsSrcDir at that directory, so other resource types aren't included when they don't need to be?
from jasmine-maven-plugin.
We're using JavaScript in multiple places in the app so unfortunately I can't limit to a single directory.
You're copying the files using a IOFileFilter and it looks like it's possible to add some kind of filename filter fairly easily (WildcardFileFilter).
I may have a bash at implementing a file filter sometime soon.
from jasmine-maven-plugin.
Cool. I just ask for your help in providing unit tests for it. I'd prefer for it to be configurable via a boolean property in AbstractJasmineMojo, because part of the reason for the existing behavior was feedback from teams who needed exactly the behavior you're trying to avoid :)
from jasmine-maven-plugin.
As of version 1.3.1.0 files are no longer copied to the target directory so this issue is no longer relevant.
from jasmine-maven-plugin.
Related Issues (20)
- Jasmine-Maven plugin error in Windows platform HOT 1
- antlr error HOT 1
- ReferenceErrors when running in Jenkins with symlinked JENKINS_HOME HOT 3
- How to use phantomjs 2.1.1 HOT 1
- Jenkins Maven Integration with Jasmine broken since 2.2 (Test results not shown) HOT 2
- Cannot make it work with ManualSpecRunner HOT 2
- Allow users to configure tests to run in a random order HOT 2
- turnoff the default reports generated by this plugin and print only the custom reporter messages HOT 1
- Can't customize ChromeDriver on 3.0-alpha-01 HOT 2
- Update the github pages site HOT 1
- Unable to set WebDriver IE specific capability ignoreProtectedModeSettings HOT 2
- Chrome version 74 HOT 4
- The documentation page is down HOT 3
- Blocked testing with latest version HOT 11
- Cannot make it work with RemoteWebDriver and Docker HOT 5
- timeout error after waiting for 300 sec with version 3.0-beta-01 HOT 2
- jasmine:bdd (version 3.0-beta-01) opens browser but jetty gives 403 HOT 3
- Broken link for usage page HOT 2
- The link to documentation at github is broken. HOT 5
- plugin doesn't work with Chrome version 117 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jasmine-maven-plugin.