Leave jasmine.js as a separate file about jasmine-maven-plugin

[searls]

I can see your point, but I don't view this as much of a big deal. Part of the point of generating a SpecRunner at all is so that it can be an isolated black box that people don't need to peak into.

I could buy a duplication argument, though, since right now two runners means two inline copies of the Jasmine dependencies. If you'd like to implement it and send a well-tested pull request, I'd likely accept it.

[gimmi]

That's not a big deal, but this kind of "mixing" framework code and application or test code feel to me like taking the sources of JUnit and copy it in my project, rather than just adding junit.jar in the classpath... Maybe my mind is rotten by compiled languages :)

Anyway the first question i've asked myself the first time i opened SpecRunner has been: "is this just a dump of jasmine or it has been modified in some way to fit HtmlUnit/maven/whatever need?". With a reference to a file named jasmine-1.0.js I probably never ask myself that question.

If I have some time i will prepare you a pull req.

[searls]

Ah, I can understand the concern more now. None of the Jasmine files are modified.

I actually started out versioning all of the JS & CSS dependencies in my own nexus and hosting them on a google code repo so that I could import them in the plugin's POM. That would have made getting into Maven Central more difficult so I ended up pulling them into the project repo itself, so what you're suggesting would probably be easier than it initially was, for what it's worth.

[bertBruynooghe]

I would also like to request this feature, as that would help a lot in developing in IntelliJ IDE: that way it would be possible to jump directly from my test code to the jasmine source code without having it to put also in my source tree (and having possible version issues).

[klieber]

Starting with 2.0-alpha-01 jasmine is pulled in using webjars so this issue is no longer relevant.