support for schema-qualified object names (for PostgreSQL) about honeysql

[ddellacosta]

It's totally do-able:

> (require '[honeysql.core :as hsql])
nil
> (hsql/format
     (hsql/build :select :interesting_column :from :other_schema.important_table))
["SELECT interesting_column FROM other_schema.important_table"]
>

Is there another scenario where you're having trouble with this?

[avandras]

Hm, that works, thanks. What I could not figure out is the same for function calls, based on this:

(require '[honeysql.core :as sql]
         '[honeysql.helpers :refer :all])

(sql/format 
  (-> 
    (select :wal_bytes_from_zero) 
    (from :%other_schema.get_database_cluster_information)))
["SELECT wal_bytes_from_zero FROM other_schema(get_database_cluster_information)"]

instead of

["SELECT wal_bytes_from_zero FROM other_schema.get_database_cluster_information()"]

[piranha]

How about (sql/call :other_schema.get_database_cluster_information)?

[ddellacosta]

Yeah, to follow on what @piranha is saying I'm not sure how to do it other than something like

(hsql/format
  (hsql/build :select :wal_bytes_from_zero
              :from (hsql/call :other_schema.get_database_cluster_information)))

If I think of a way to use the % shorthand I'll add it to this issue...

[piranha]

I don't know, I prefer sql/call much more than :%, since then query starts to look like line noise, plus you can't pass more than one argument (and it needs to be a column!).

[avandras]

@piranha that's neat! I even agree that sql/call is a cleaner solution - I've just missed this in the readme. Thanks, guys!