Adding a subquery aliasing example to the doc about honeysql

[bcambel]

+1 , 2 years and still valuable :)

[devn]

+1 to this. This would be nice to include in the big example in the README.

[jrdoane]

For what it's worth, I'm going to play devil's advocate here. They (sub-queries and aliasing,) don't really behave any differently separate than when you put them together. It just writes strangely which is why when I do this, I'm working with the map directly instead of using helper functions because it's not unrealistic that you'll want to re-use or alter certain stanzas.

I see the example above and would be tempted to write it without the helpers:

(sql/format {:select [:%count.*] :from [[{:select [:*] :from [:client]} :foo]]})

Personally, the only thing that looks weird is the sub-query itself, so you could just pull it apart and it looks normal again.

(def sub-query {:select [:*] :from [:client]})
(def full-query {:select [:%count.*] :from [[sub-query :foo]]})
(sql/format full-query)

For what it is worth, there are sub-query examples and aliasing examples. Is it really not obvious that the two can be put together and still work?

[seancorfield]

@jrdoane I'm looking over the README and don't see examples of either. Where are you seeing examples of these? (figuring out where best to add more examples)

[seancorfield]

I've just added an example of aliasing to the README. There are two examples of nested selects but neither lend themselves to adding aliasing. PRs welcome to improve the README in this area!

[seancorfield]

Closing this in the absence of a PR or further feedback. FWIW, I agree with @jrdoane that these things don't behave any differently together than they do separately: (-> ... (from [sql-expression the-alias]) ...) so I'm not sure what could be clearer in the README (but I'll certainly accept PRs for improvements -- just bear in mind that the README can't include every combination of features in the library because that would be huge!).