Feature request: More compatibility with regular Emacs modes about doom-modeline

[seagle0128]

Appreciate it for your great suggestion!
It's true the goal is keeping minimalistic, but I'm also open to accept PRs which are simple, nice and useful.

The global and buffer-position are nice to add to the mode-line. I will merge soon. Please test then.
Thanks a lot, again!

[weirdNox]

That's great to hear! :D

[weirdNox]

Ah, btw, in case you are wondering about the spaces in buffer-position, I tried to keep the original padding of 2 spaces like "__%l:%c %p__" in any combination of line-number-mode and column-number-mode and the percentage.

When the mode-line-position is empty, it will keep only two spaces "__", the one in buffer-position and the one in the main modeline spec.

I chose to do it like this, because if some mode completely replaces mode-line-position, they may choose to not pad it, but will at the very least have 1 space of padding (like pdf-view-mode, which only pads the string to the left).

[seagle0128]

Thanks for the explanations, @weirdNox! I will think about it.

I've added global-mode-string in 4d4ec2e.
Regarding buffer-position, I have concerns about mode-line-percent-position and column-number-indicator-zero-based which are introduced in 26. Need more considerations for 25...

[weirdNox]

Ohh, I had no idea, I just went to see the default value in my Emacs, which is v26, and adapted from it!

Maybe you could add a check outside with boundp, and if not defined, you could create them with a defvar.

Or instead of using them directly, using something like

(defvar doom-modeline-percent (or (bound-and-true-p mode-line-percent-position) '(-3 "%p"))
  "...")
(defvar doom-modeline-column-zero-based (or (bound-and-true-p column-number-indicator-zero-based) t)
  "...")

(...if the macro bound-and-true-p is defined in 25 ahah)

I don't know, your call :)

[weirdNox]

Thanks! :D