Panel height taller than rest of the bar about doom-modeline

[seagle0128]

I cannot access the image. Can you attach the image directly?
Well, I guess the issue is caused by fonts. Did you install all-in-icons fonts?

This package requires the fonts included with all-the-icons to be installed. Run M-x all-the-icons-install-fonts to do so.

[WolfeCub]

Yeah I installed all-the-icons through emacs. Here's the embedded image:

Thanks!

[seagle0128]

Thanks for providing the embedded image to troubleshooting!

I couldn't reproduce this issue locally.

Would you please let me know more details?

1. OS
2. Emacs version
3. doom-modeline version
4. Color theme
5. Emacs fonts
6. Any error messages?
7. Other clues.

I suggest to upgrade doom-modeline to the latest version, set doom-modeline-height, e.g. (setq doom-modeline-height 26).
Or set different fonts (I recommend Source Code Pro), and observe the changes.

[WolfeCub]

1. Arch Linux - 4.18.9-arch1-1-ARCH
2. 27.0.50
3. 20180926.920
4. Custom theme
5. Fira Mono and Fira Code for the fallback.
6. No error messages.
7. No sorry :(

I have the latest version from MELPA and i've tried doom-modeline-height but regardless of what I set it too it's always slightly bigger.

I'll try out some different fonts.

[seagle0128]

Thanks for the quick response!

It's very wired. Please change the font size or change to other fonts.
I suspect the font is too large and exceed the mode-line height. To prove it, you can increase doom-modeline-height to 29 or larger, or decrease font size to 12 or smaller (I noticed you are using Fira 15).

[seagle0128]

Or try this:

M-x eval-defun

(doom-modeline-def-modeline 'main
                            '(workspace-number window-number evil-state matches " " buffer-info buffer-position " " selection-info)
                            '(global buffer-encoding major-mode process vcs flycheck))

[WolfeCub]

I tried that elisp snippet and the same issue occurs. I also tried Fira 12 and mode-line height of 29 and the issue also occurred. Do you have a font I could try that you know works for sure?

[seagle0128]

Would you please try Source Code Pro 12 cor DejaVu Sans Mono 12.
Actually I tried to recreate this issue with Fira 15 locally. I believe it's a font size issue. If you decrease the font size, it looks better. IMO it's not an issue, since the panel height is same as the font height. If you use this snippet, you could notice the bar is removed. The fact is the bar height (doom-modeline-height) is smaller than the font height, as well as the panel height in this case.

(doom-modeline-def-modeline 'main
                            '(workspace-number window-number evil-state matches " " buffer-info buffer-position " " selection-info)
                            '(global buffer-encoding major-mode process vcs flycheck)

[WolfeCub]

This is the result if I swap the font to DejaVu Sans Mono 12.

[seagle0128]

@WolfeCub can you try DejaVu Sans Mono 10 or 9?

BTW: why there is no window-number panel and evil indicator in the screenshot?

[WolfeCub]

This is with DejaVu 9:

The evil indicator I have disabled. I'm not sure about the window number panel. That never showed up for me.

[seagle0128]

OK. I see. You didn't enable winum-mode or window-numbering-mode.
Can you eval this snippet to get the height of mode-line? I suppose it's greater than doom-modeline-height.

(- (elt (window-pixel-edges) 3) 
   (elt (window-inside-pixel-edges) 3))

And please use (setq doom-modeline-height 29) to check the looks.

[WolfeCub]

So when I start emacs doom-modeline_height is 23 and that snippet evals to 34. If I run (setq doom-modeline-height 29) and re-eval that snippet it evals to 36. Repeating one more time and running (setq doom-modeline-height 36) the snippet evals to 39.

[seagle0128]

So the actual mode-line height is greater than doom-modeline-height since the different font size. Evals (frame-char-height) to get it..
This is as designed, and it's native behaviors of mode-line.
You can let doom-modeline-height >= mode-line height after specifying the font. I believe it can address this issue.

[seagle0128]

I think I found a workaround to adjust the bars height and make the mode-line look better.

[WolfeCub]

Great! Thanks for your help.

[WolfeCub]

One other thing I noticed was the box get's taller when there's 0/0 results then when it's matching something.

[seagle0128]

Hi,
I cannot reproduce with the latest version. Please update and retry.
In your case, I also suggest (setq doom-modeline-height 39). The panel height exactly equals actual mode-line height. Thus means bar height <= mode-line height == panel height.

[WolfeCub]

That was with the latest version. Setting a height of 39 works perfectly actually. Would there be a good way to determine this number problematically so it adjusts when I change font?

[seagle0128]

I made a several commits and please update again. I'm not sure if it's perfect but deserves to try.
It works very well on my laptop (Emacs 26.1, macOS Mojave).