motr unit tests reports memory leaks about cortx-motr

[nikitadanilov]

Yes, some unit test are expected to leak memory, it's all right.

[johnbent]

Thanks @nikitadanilov , should we close this issue then?

[ttwalkertt]

Yes, let's close it but it would be helpful to document the fact that the tests will show memory leaks. Otherwise people, like me, make get a little worried. Tim Walker Product Design Systems Engineering, Seagate Technology [phone]

…

________________________________ From: John Bent <[email protected]> Sent: Wednesday, July 29, 2020 1:13:05 PM To: Seagate/cortx <[email protected]> Cc: Tim Walker <[email protected]>; Author <[email protected]> Subject: Re: [Seagate/cortx] motr unit tests reports memory leaks (#86) Thanks @nikitadanilov<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nikitadanilov&d=DwMCaQ&c=IGDlg0lD0b-nebmJJ0Kp8A&r=NW1X0yRHNNEluZ8sOGXBxCbQJZPWcIkPT0Uy3ynVsFU&m=ngJrNeMqz3x9bUwPawwVNnjovH6_EjhcdYOfVLFLUWY&s=dXw_uNiyhsrEpqK-9NRw8VWVU6p22Bjy8Zm-wue_ik4&e=> , should we close this issue then? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Seagate_cortx_issues_86-23issuecomment-2D665790193&d=DwMCaQ&c=IGDlg0lD0b-nebmJJ0Kp8A&r=NW1X0yRHNNEluZ8sOGXBxCbQJZPWcIkPT0Uy3ynVsFU&m=ngJrNeMqz3x9bUwPawwVNnjovH6_EjhcdYOfVLFLUWY&s=kKzUcILB8_LcpeMIc7FeDUCTvFteEq2WoXnHKi5SDnI&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAX7PJDH3622Z4CXGPTKSRTR6BKCDANCNFSM4PKZOF7A&d=DwMCaQ&c=IGDlg0lD0b-nebmJJ0Kp8A&r=NW1X0yRHNNEluZ8sOGXBxCbQJZPWcIkPT0Uy3ynVsFU&m=ngJrNeMqz3x9bUwPawwVNnjovH6_EjhcdYOfVLFLUWY&s=sBDAT_ra07uU1Wg8T6Dlo8pX_Y9Q64FkUQKFGSI_kO4&e=>.

[johnbent]

Probably the best place to document this would be in the output of the test program itself. @nikitadanilov , you agree?

[nikitadanilov]

You mean if somebody went through all the UT-s, clarified with the authors whether leaks are expected and then modified the ut bench to print "expected" or "unexpected" accordingly? Yes, that would be useful.

[johnbent]

Yes, that would be awesome! @truptiatseagate can you please assign this work to someone?

[truptiatseagate]

@anaghadeshmukh Pls reassign as appropriate

[anaghadeshmukh]

Rajkumar will work on this after his current open source task is complete.

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @huanghua78 @mukundkanekar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[nkommuri]

Hi @johnbent @truptiatseagate @anaghadeshmukh , we've discussed this and came up with 2 options.

Option 1: Document a generic statement mentioning some of the UTs will have memory leaks which is expected.

Option 2: Scrub all the UTs, find out which UTs are leaking memory and it is expected or not. This requires some effort.

Please suggest.

[cortx-admin]

Trupti Patil commented in Jira Server:

I think option 1 can be used as the short term one and the option 2 can be longer term e.g. in PI5 and may spread over PI6 if there is extensive work to assess each UT closely as why there is memory leak etc and the number of UTs are too many.

Since this issue does not have any impact to the end-user, we will need to weigh its priority against the rest of our backlog. Thanks.

[r-wambui]

JIra ticket link: https://jts.seagate.com/browse/EOS-23725

@johnbent @truptiatseagate @anaghadeshmukh @nkommuri Is the solution to this issue for the long term be at the backlog and should we document for the short term solution?

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[r-wambui]

Hi @truptiatseagate has option 1(Add documentation into the test program itself) been fixed or still in progress? For option 2 (Finding out whit unit tests are causing the memory leaks) could you please let's know if someone is assigned to the task?

[nkommuri]

JIra ticket link: https://jts.seagate.com/browse/EOS-23725

@johnbent @truptiatseagate @anaghadeshmukh @nkommuri Is the solution to this issue for the long term be at the backlog and should we document for the short term solution?

yes @r-wambui

[cortx-admin]

Nagakishore Kommuri commented in Jira Server:

As part of option 1, planning to print following statement at the beginning of run-ut. 

 

diff --git a/scripts/m0 b/scripts/m0

index ace98a6..42cdd10 100755

--- a/scripts/m0

+++ b/scripts/m0

@@ -325,6 +325,11 @@ UT output:    $RUNDIR

EOF

}

 

+if [[ "$1" == "run-ut" ]]; then

+   echo "Please note that we have observed memory leaks in some UTs which we are going to address in future releases"

+fi

CMD=

OPTS=

while [ $# -gt 0 ]; do

 

 

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[cortx-admin]

Donald R Bloyer commented in Jira Server:

[~530903] [~934754] [~934462]

have addressed most of this in our last several months memory leak 'hunt'?

[anaghadeshmukh]

+ Chandra Regards, Anagha

…

________________________________ From: cortx-admin ***@***.***> Sent: Monday, March 28, 2022 4:01 PM To: Seagate/cortx-motr ***@***.***> Cc: Anagha Deshmukh ***@***.***>; Mention ***@***.***> Subject: Re: [Seagate/cortx-motr] motr unit tests reports memory leaks (#77) This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Donald R Bloyer commented in Jira Server: [~530903] [~934754] [~934462] have addressed most of this in our last several months memory leak 'hunt'? — Reply to this email directly, view it on GitHub<#77 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APACUDHD7TYXKHG6D6N43XTVCGDBJANCNFSM4SCEZ5TA>. You are receiving this because you were mentioned.Message ID: ***@***.***> Seagate Internal

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[novium258]

@anaghadeshmukh Did we get an answer on this one?

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[chandradharraval]

Hi @novium258,
This memory leak is for one of the unit test and not in the code flow. Due to that we have not prioritize it. We will be fixing the same in our current PI

[nkommuri]

Closing. No plans to fix memory leaks in UTs right now. We will take this up in future. Leaks in main stream code will be prioritized and fixed.

[cortx-admin]

Bhargav Dekivadiya commented in Jira Server:

NA

[cortx-admin]

Bhargav Dekivadiya commented in Jira Server:

Github issue : [https://github.com//issues/77] is closed

[cortx-admin]

Bhargav Dekivadiya commented in Jira Server:

Corresponding Github issue : [https://github.com//issues/77] is closed