Do not assume `sizeof(int)==sizeof(uint64_t)` about cortx-motr

[u-u-h]

This also manifests itself in places where 0xffffffffffffffff is used as a largest value in an enum, which by C standard can only contain int values.

[stale]

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @huanghua78 @mukundkanekar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

[huanghua78]

Thank you for report this.

Maybe:

0xffffffffffffffffull

can be used?

[u-u-h]

Of course not. If you look at the C99 standard (e.g. http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf) 6.7.2.2 Enumeration specifiers [...] Constraints The expression that defines the value of an enumeration constant shall be an integer constant expression that has a value representable as an int. [...] Each enumerated type shall be compatible with char, a signed integer type, or an unsigned integer type. The choice of type is implementation-defined, but shall be capable of representing the values of all the members of the enumeration. The range of unsigned long long can of course differ from that of an int. The most portable way is using INT_MAX; while that may not be equivalent if your intent was to have an all-bits-1 constant it will avoid undefined/implementation-defined behavior. Beware that the size of the enum type can be different from int; the enumeration constants are.

…

-uuh Am 21. November 2020 05:25:19 MEZ schrieb Huang Hua <[email protected]>:

Thank you for report this. Maybe: ``` 0xffffffffffffffffull ``` can be used? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #188 (comment)

-- Utz-Uwe Haus

[nikitadanilov]

motr source code is not standard C, far from it. We depend critically on gcc extensions for one thing. Current code works fine under gcc and llvm (see darwin branch), which is good enough for us.

[huanghua78]

This is explained by nikita.