Coder Social home page Coder Social logo

Comments (3)

moriaab avatar moriaab commented on July 20, 2024 1

If I try to add "0x" to a pre_code, there is no exception. The following happens:
to_hex fails here https://github.com/enigmampc/enigma-core/blob/develop/enigma-core/app/src/networking/ipc_listener.rs#L309
and then IpcResponse::Error is created (as expected).

@elichai, as far as I understand, we have 2 relevant unwraps:
https://github.com/enigmampc/enigma-core/blob/develop/enigma-core/app/src/networking/messages.rs#L219
https://github.com/enigmampc/enigma-core/blob/develop/enigma-core/app/src/main.rs#L37
But I don't see any problems with them in this case.
This defect reveals some issue. Although the problem is wrong user input, system error is returned. Is this what we want?

from enigma-core.

elichai avatar elichai commented on July 20, 2024

That's weird. can you give me a sample of data?
I can't see any unwraps there.

from enigma-core.

moriaab avatar moriaab commented on July 20, 2024

This defect is planned to be fixed as part of general improvement of treating wrong inputs for deployment and computation of secret contracts.

from enigma-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.