Comments (15)
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.
It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
from scratchaddons.
My expectation here is that the add-on is supposed to know the existence of the sprites inside the closed folders. I am aware that the issue is caused by the folders being treated as sprites. The reason why we should be able to search for sprites inside closed folders is because that way, we can instantly locate the sprites without having to plow through the folders we have created.
from scratchaddons.
What about the following fix:
When the user searches for a sprite by name...
- Remember which folders are opened and which ones are closed
- Open all folders
- Search for the sprite
When the search is cleared, close the folders that were closed before the search.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.
from scratchaddons.
Last time I checked, folders
does expose a few methods as a module. Maybe something's there that would be useful for this.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
from scratchaddons.
@iqnite Sounds reasonable.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.
Yes, indeed we can search for subfolders in a folder... And we can search folders here?
from scratchaddons.
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.
from scratchaddons.
It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
But then you have to, before your search, open all the folders you want to search in.
I think it should always show folders if their name or a name of a sprite inside of them matches the search query, regardless of if they're opened or closed.
from scratchaddons.
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Folder closed: Folder opened:
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
If we weren't able to search for contents of closed folders, we would have to open EVERY folders in able to search for all sprites, by the time we would have already located where the sprite was.
By the way, the addon could do well with an option to open or close every folders.
from scratchaddons.
That's the way to go 😀
from scratchaddons.
Is there a way to share info between addons?
from scratchaddons.
@iqnite In this case, I think ideally the folders addon should expose 2 functions: one that opens all folders, and a getter/setter for the state of which folders are open.
Consider that theoretically, folders can be renamed or deleted while a search is taking place, so it needs a bit of validation.
from scratchaddons.
Is there a way to share info between addons?
For prototyping, it's okay to attach things to the global window
object or using any other way to expose data/methods. Before actually merging it, we'd try to use standard JS modules instead.
from scratchaddons.
Related Issues (20)
- `mediarecorder`: custom shortcut to stop- and start recording HOT 2
- 3.0 Scratchblocks on forums: Apply custom block styles HOT 1
- Jump to custom block definition: add context menu option HOT 1
- Remove `handle-licenses.js` HOT 1
- Remove unnecessary `MANIFEST_VERSION` constants HOT 1
- Rearrangeable custom block inputs: Adding or rearranging an empty-string label creates "%l" labels. HOT 7
- Settings page works - but addons don't - on v1.38.1 HOT 37
- Service worker restart breaks regex matches
- Scratch Addons refuses to work on some pages in newest Chrome update. HOT 2
- Auto-hiding palette does not work with dropdowns or text regions HOT 1
- Hover over a custom block input to see the name of it as a tooltip HOT 1
- Legal: Should the licenses page include the author and copyright year? HOT 1
- An extension to clear certain lists on save HOT 5
- Interpolation HOT 3
- Finding the root cause of the constant log-outs HOT 12
- Invalid addon.json causes error page to repeatedly open
- Addons turning off automatically maybe because of synchronization HOT 2
- `turbowarp-player`: gamepad, fullscreen and player options do not follow darkmode scheme HOT 1
- "Add this project" button in cloud games popup is not centered
- variables on the variables tab for this sprite only are showing variables from different sprites
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scratchaddons.