Comments (5)
I sent you a PR to fix your last test: https://github.com/SiegfriedEhret/angular-localForage/pull/1
The fact is, you call the expect outside the promises, so it will be called before the test has been completed and result will always be undefined.
You might change the code to include then second callback of then (the first one is success, the second one is fail) or your last test might never finish when it fails.
from angular-localforage.
https://github.com/SiegfriedEhret/angular-localForage/pull/2 fixed it for real :)
from angular-localforage.
THANK YOU !!
from angular-localforage.
By the way, once you're done, if you can update the tests on this repo it would be really nice !
from angular-localforage.
That's exactly what I was planning to do ;)
from angular-localforage.
Related Issues (20)
- Versioning DB HOT 3
- Bump localForage to 1.4.2
- Clean up and update depedencies HOT 1
- Support passing back an object on multi-getItem lookup
- import/require should return module name HOT 6
- question: angular-localForage support indexedDB, webSQL, localstorage, but i don't know which one it is the default choice HOT 1
- Q: Is there the maximun about angular-localForage HOT 1
- does bind() a two way binding? HOT 4
- Change dependencies from dist to source? HOT 4
- Using directive and deleting value keeps 3 characters in the field HOT 5
- Storing huge object freeze my app HOT 9
- Use getItem instead of iterate for small getItem array lookups HOT 2
- Facebook In-App Browser HOT 6
- $$hashKey is now being saved on setitem HOT 8
- i get this error when i'm tring to use electron app with angular-localforage HOT 5
- Correct usage with webpack HOT 3
- iOS safari support indexedDB HOT 6
- Support for AngularJs 1.6! HOT 4
- Nested Promises do not work HOT 3
- setItem call does not return an angular promise but an ES6 promise HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-localforage.