Coder Social home page Coder Social logo

Comments (5)

ocombe avatar ocombe commented on June 14, 2024

I sent you a PR to fix your last test: https://github.com/SiegfriedEhret/angular-localForage/pull/1
The fact is, you call the expect outside the promises, so it will be called before the test has been completed and result will always be undefined.

You might change the code to include then second callback of then (the first one is success, the second one is fail) or your last test might never finish when it fails.

from angular-localforage.

ocombe avatar ocombe commented on June 14, 2024

https://github.com/SiegfriedEhret/angular-localForage/pull/2 fixed it for real :)

from angular-localforage.

SiegfriedEhret avatar SiegfriedEhret commented on June 14, 2024

THANK YOU !!

from angular-localforage.

ocombe avatar ocombe commented on June 14, 2024

By the way, once you're done, if you can update the tests on this repo it would be really nice !

from angular-localforage.

SiegfriedEhret avatar SiegfriedEhret commented on June 14, 2024

That's exactly what I was planning to do ;)

from angular-localforage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.