Coder Social home page Coder Social logo

Comments (3)

scottcheng avatar scottcheng commented on September 17, 2024

Hey @anoopelias, great to hear that cropit is working well for you, and thanks for the proposal! That definitely sounds like a good idea, but one of the principles I have for cropit is that I wanted to keep it minimal, in particular not to have CSS in it, so the user of it can style it from scratch instead of overriding the existing ones. However in my opinion, different people would most likely want to style - and + in different ways, and give them different behaviors (e.g. different zoom steps). Therefore I've exposed simple APIs to get/set zoom, which I suppose you are using, to achieve such functionality, and while it will definitely be useful to some, I would like not to have extraneous options and complex design in cropit. Hope you understand!

from cropit.

anoopelias avatar anoopelias commented on September 17, 2024

@scottcheng While adding - and + I saw there are a few issues to be taken care of, apart from css. Like this for example. However I understand that you don't want to increase complexity in terms of zoom step configuration etc. I also suspected it might be overkill.

Off topic: My cropit based implementation went through QA on mobile devices (Android Chrome/Firefox) yesterday and it worked like a charm. :). Absolutely no change needed.

from cropit.

scottcheng avatar scottcheng commented on September 17, 2024

Good point about the subtleties 👍

Great to hear that it's working well for you! It works on mobile thanks to the kind folks on github :)

from cropit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.