Function arguments in multiple lines. about scimlstyle

[ChrisRackauckas]

One per line is insane to read when you get to like 30 keyword arguments. Closing parenthesis is fine on its own line though.

@YingboMa what do you think?

[isaacsas]

Given that a column width is being enforced, it shouldn’t be hard to see the closing parenthesis if it is on the same line as arguments. There is something to be said for saving vertical space too.

[isaacsas]

It also (to my eyes), breaks the convention that the indentation can be quickly scanned to see where a function ends. Now one has to actively ignore parentheses that arise at the same indentation level (will editors handle that without issues when one uses code folding?).

[cossio]

Code folding is indeed a bit strange when the closing parenthesis is not indented. You get two folds: One for the args and another for the function body. But maybe that can be solved on the VS Code Julia Extension? julia-vscode/julia-vscode#2907

[isaacsas]

That doesn’t seem too bad! But there are many different editors people use, and I’d worry a decent number of them may have issues.

[YingboMa]

One per line is insane to read when you get to like 30 keyword arguments. Closing parenthesis is fine on its own line though.

Yeah, I agree. I made sure JuliaFormatter preserves

function my_large_function(argument1, argument2,
                           argument3, argument4,
                           argument5, x, y, z)
    ...
end

[cossio]

@YingboMa Is it guaranteed to preserve:

function my_large_function(
    argument1, argument2,
    argument3, argument4,
    argument5, x, y, z
)
    # code
end

too?