Coder Social home page Coder Social logo

Comments (6)

stevengj avatar stevengj commented on May 29, 2024 1

Note that using Vector for an argument type is also probably overtyped; you probably want AbstractVector.

from dassl.jl.

stevengj avatar stevengj commented on May 29, 2024 1

Also ::Int is overtyped; you want ::Integer (if you want to declare a type at all). In general, the Julian approach is to make your code as generic as possible, within the bounds of correctness and clarity.

from dassl.jl.

ChrisRackauckas avatar ChrisRackauckas commented on May 29, 2024

Those are all really good points. I would like to see these changes as well.

from dassl.jl.

pwl avatar pwl commented on May 29, 2024

Fixed with 838e072, hopefully I didn't miss a spot. Sorry for these bugs, this package was written two years ago when I had little clue about Julia (REQUIRE still contains Julia 0.2:-)). I also pushed a v0.0.5 tag.

from dassl.jl.

pwl avatar pwl commented on May 29, 2024

So because we have to update METADATA anyway it's a good moment to move the package to JuliaDiffEq before doing that.

from dassl.jl.

stevengj avatar stevengj commented on May 29, 2024

Thanks! (Note, by the way, that most Julia developers seem to be moving away from FactCheck and back to Base.Test, now that the latter has @testset; Base.Test has all of the functionality of FactCheck with a much more Julian syntax.)

from dassl.jl.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.