Comments (5)
How do you want to do this? There are 4 classes of EightTerm Coefficients, and they each define their own self.run method where the coefs dictionaries are defined.
Two proposals:
- put it in EightTerm.coefs getter
If no isolation terms are detected, initialize at zero and return - put it in the EightTerm..coefs setter
If not isolation terms are detected, initalize at zero and set the _coefs attribute with this
Or something else?
from scikit-rf.
so i think we want to
- change the init to look for isolation temrs as a kwarg to
EightTerm
, so that we could use it in the correction. - use it in the correction (
EightTerm.apply_cal
). this may require terminate/unterminate to be updated as @Ttl suggests. - use it in
EightTerm.embed
. (low priority, but needed for tests) - have default zero-filling fall-back behavior as you suggest above.
from scikit-rf.
also putting the isolation in coefs getter, as you suggest solves the problem is redundant implementation, which is important . after looking the EightTerm.run
directly accesses self._coefs, so it bypasses the setter. so going with the getter makes the most sense.
from scikit-rf.
are we ready to close this then?
from scikit-rf.
from scikit-rf.
Related Issues (20)
- Uncertainties in Vector Fitting fit parameters HOT 11
- vector fit crashes when npoles >= npoints/2 HOT 3
- some observations about vectorfit operation
- Tests are failing HOT 11
- add statics function i.e. violin plots for a number of sample measurements HOT 1
- Analytical Matrix Inversion in subnetwork growth (Filipsson/Compton) vs General Numerical Inversion following Hallbjörner HOT 9
- De-embedding procedure help request HOT 3
- Trying to use pre-commit, doesn't like the .pre-commit-config.yaml regex. HOT 3
- S-parameter calculation incorrect for 3-port circuit HOT 46
- Phase mismatch between symmetrical error networks HOT 3
- `n_twoports_2_nport` does not work for more than 10 ports, similar to #947. Work around included. HOT 1
- De embedding multi frequency 2port network touchstone files HOT 4
- module 'collections' has no attribute 'Sequence' HOT 2
- Support request for network.z_time_step HOT 2
- Adding support to the Keysight N5242B VNA HOT 3
- NanoVNA connection syntax out of date in example Measuring a 4-Port With The 1.5-Port NanoVNA V2 HOT 1
- error in the def "write_spice_subcircuit_s(self, z0, file: str) -> None: " HOT 4
- Importing scikit-rf imports many modules and is slow HOT 5
- PR Labeler does not work HOT 1
- skrf.NetworkSet.interpolate_from_params raises exception if any identical parameter values are in a network set where as skrf.NetworkSet.interpolate_from_network using the same parameters does not. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scikit-rf.