Coder Social home page Coder Social logo

Comments (3)

ctrueden avatar ctrueden commented on July 28, 2024 1

I did some digging. The reason it freezes is not because min and max are null—that would throw an NPE after all. It's because min defaults to Integer.MIN_VALUE and max to Integer.MAX_VALUE. The UI builder then proceeds to try to make a slider or scroll bar with a massively huge range, and the CPU goes to 100% indefinitely. The problem is this and that lines of code in the DefaultWidgetModel.

A possible fix would be to change the code that creates the JScrollBar or JSlider to be more conservative about what it feeds to those constructors. This would also guard against the case of explicit min="-1000000000", max="1000000000" sorts of inputs.

from scijava-ui-swing.

imagejan avatar imagejan commented on July 28, 2024

Thanks for digging, @ctrueden!
I think we can tackle this at the same time as allowing non-integer step sizes in sliders (see #31), by adjusting the step size in case the number of possible steps gets unreasonably high (the acceptable limit might have to be found by testing with different settings).

from scijava-ui-swing.

ctrueden avatar ctrueden commented on July 28, 2024

I believe I have fixed the integer cases. Handling non-integers will be more involved, though.

from scijava-ui-swing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.