Coder Social home page Coder Social logo

Comments (3)

Marcarrian avatar Marcarrian commented on June 18, 2024 1

Hey @ova2,
Thank you for your suggestion. The type definition for DistinctArray is quite complex and is hard to read especially for the users of the API. I am unsure if the added complexity outweights the disadvantages of simply using Sets. Furthermore, since qualifiers are defined in the manifest.json file, only array types are supported anyways. We might just define the qualifier as such:

qualifier: string | Array<string>

from scion-microfrontend-platform.

ova2 avatar ova2 commented on June 18, 2024 1

Hey @ova2, Thank you for your suggestion. The type definition for DistinctArray is quite complex and is hard to read especially for the users of the API. I am unsure if the added complexity outweights the disadvantages of simply using Sets. Furthermore, since qualifiers are defined in the manifest.json file, only array types are supported anyways. We might just define the qualifier as such:

qualifier: string | Array<string>

I see. This sounds good for me:

qualifier: string | string[]

from scion-microfrontend-platform.

ova2 avatar ova2 commented on June 18, 2024

Distinct arrays as type is probably better than Set because you don't need to carry all methods from Sets. You're just interested in data container with distinct values. Such type can be defined e.g. as follows: https://tompicton.com/typescript-distinct-array/

Means:

qualifier: string | DistinctArray<string>

The same for Map. Why to model a data structure as "heavyweight" Map if you only need a dictionary?

from scion-microfrontend-platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.