[dev2.0] Transactions about npoco

[DejanMilicic]

Begin/Completed are very handy when you implement Unit of Work pattern. Besides, it is bad practice to introduce breaking changes. And finally, good documentation is most important thing.

[zii-dmg]

And what is difference between BeginTransaction/CompleteTransaction and Database.GetTransaction/Transaction.Complete for unit of work pattern (as Transaction wrapper use these methods inside)?

[DejanMilicic]

Nothing. That is the whole point. Breaking changes on one hand. What is on the other hand besides nitpicking?

[zii-dmg]

Sorry but only nitpicking and no redundancy.

[schotime]

BeginTransaction/Complete/Abort need to be there when you can't directly surround the code with a using block etc.
I don't think it is an issue.

[zii-dmg]

But you can use Transaction wrapper without "using block":

• Database.GetTransaction = Database.BeginTransaction
• Transaction.Complete = Database.CompleteTransaction
• Transaction.Dispose = Database.AbortTransaction

It is 1-to-1 mapping + "using" if can/needed.

[schotime]

True, however then I would have to store the transaction object somewhere as well as the database object.

[zii-dmg]

Partially true because you already have BaseTransaction property for this which not long ago was public.

[schotime]

BaseTransaction was not for this (was used to manage nested transactions). This has now as you have mentioned been made internal.