OptionShowCount incorrectly renders with items below 1% about progressbar

[schollz]

Yeah, a fractional percentage is a great idea. I'll happily take a PR for this

[schollz]

Started it ce5fc5d

[ikonkere]

Well, if you don't mind my whole 3 days' familiarity with golang ;) i can surely patch

progressbar/progressbar.go

Line 317 in 77e36af

updateBar := p.state.currentPercent != p.state.lastPercent && p.state.currentPercent > 0

to introduce a forceRender flag that will invalidate the bar every time an Add is performed.

Besides, there's also a related bug: config.maxBytes isn't used anywhere, but checked for during invalidation:

progressbar/progressbar.go

Line 325 in 77e36af

if updateBar || p.config.showIterationsPerSecond || p.config.maxBytes > 0 {

[ikonkere]

Oops, you started the PR while i've been typing my comment on how to do it :). After looking into the code, my previous comment is still relevant, updating percent variable type to float won't help in my particular case.

[schollz]

Okay cool! If you'd like, I would love if you submit a patch as a PR. The decimals can come later (it will require fixing a lot of tests). Don't worry that you only have 3 days familiarity with Go :) I will be available to assist or answer any questions or anything else! Please don't hesitate to ask. Welcome to Go!

[ikonkere]

Cool, it's quarantine anyway and i've got nothing better to do :). But i mean are you okay with what i'm proposing: forceRender flag exposed through an Option and added to quoted lines 317 or 325?

[schollz]

@ikonkere That seems fine to me! If you want to, you can also make a test that shows your problem so that I don't accidentally introduce something in the future that causes it again :) No worries if you don't want to.

[ikonkere]

Ok, made a PR: #55. I actually wanted to totally rework how rendering is done (you can see here if you want https://github.com/ikonkere/progressbar/tree/invalidate), but making async CLI UI components in Go turned out way harder than i expected ;).

[schollz]

Your PR looks good. I'll check it out soon for merge (I think its just fine!).

As for async rendering, I was actually trying to avoid it here. There are reasons you might want to do it, so please fork away (I would add a ticker to yours if I were you to avoid high CPU)! But for this project I'm trying to keep a progressbar that is essentially a state machine, where it only updates once it has some update.

[ikonkere]

Yeah, asynch rendering kinda contradicts "simple", so i stashed the change within my fork for now, to think it over, but it's a good, although harsh way to get into a programming language :).

[CompeyDev]

Hey @schollz, it was mentioned that fractional percentages may be a solution:

It is possible to introduce fractional percentage...

Has this been implemented? If yes, how exactly do I utilize this? I am confused because as of now Add() does not accept floats of any kind.