Issue with safe area ignored in the floating panel’s controller when navigation bar translucency is turned off about floatingpanel

[Kohdepitcher]

After some more trial an error, the issue seems to be with UINavigationController. After I replaced my original embedded navigation controller with a new one, the issue was solved but now if I make my navigation controller's navigation bar translucent disabled, the issue comes back. It seems that changing the translucency of the navigation bar stops the safe area working correctly for the floating drawer.

[scenee]

Thank you for your report. I fixed this issue on PR #29.

[Kohdepitcher]

I've tried to use the this new branch, fix-navigation-bar-problem, in my Podfile but it hasn't fixed this issue. I've gone through the floating panel files in my project and I have noticed that some changes that you have made in the floating panel layout file is not in my floating panel layout file in my app. It's as if CocoaPods is ignoring your latest push to the fix-navigation-bar-problem branch. Ive also tried to replace the floating panel files in my project with the source files in this branch from GitHub and that didn't work as well. Maybe I should try using another branch that is newer?

[scenee]

Could you try pod cache clean FloatingPanel --all && pod deintegrate && pod install --repo-update?

[Kohdepitcher]

Same issue again, I've run that command, tried with translucency off and it still isn't working. its still got the same issue with changes in the branch not showing up in my floating panel files. Strange

[scenee]

Hmmm, what's happen on you... I can get the correct code by this Podfile.

platform :ios, '10.0'

target 'FloatingPanelSandbox' do
  use_frameworks!
  pod 'FloatingPanel', :git => "https://github.com/SCENEE/FloatingPanel.git", :branch => "fix-navigation-bar-problem"
end

[Kohdepitcher]

target 'convertio2' do
  use_frameworks!

  pod "AGCircularPicker"
  pod 'Expression', '~> 0.12'
  pod 'FloatingPanel', :git => 'https://github.com/SCENEE/FloatingPanel.git', :branch => 'fix-navigation-bar-problem'

  target 'convertio2Tests' do
    inherit! :search_paths
   
  end

  target 'convertio2UITests' do
    inherit! :search_paths
    
  end

end

Thats all that I have for my iOS target

[scenee]

It looks no problem. How can I help you...? 🤔

[Kohdepitcher]

Well I don't know what's going on, but I just downloaded the sample project from this branch. it has the all the code from the latest push and I can confirm the translucency issue is fixed in the sample project. I don't think it makes a difference but there are multiple targets in my pod file for the Apple Watch and the watch extension but I don't use the floating panel there. So I have no clue why this is happening. 🤔

[scenee]

Thanks for your confirmation, @Kohdepitcher! I merged 'fix-navigation-bar-problem' branch for convenience.
There might be a CocoPods issue, but we're not clear about the cause. If you find something wrong of this library, please let me know 😀