Comments (2)
Even if we were to code a function having a different return type depending on the parameter (refactor of validatePathParam below), it would already break in the API methods as the output would be string | something-else
and not just string
. In our case, we would like an error only when the developer is using the lib, not before that.
export function validatePathParam<T extends string | number | undefined>(
name: string,
param: T,
): typeof param extends undefined ? TypeError : string {
type OutType = typeof param extends undefined ? TypeError : string
switch (typeof param) {
case 'string':
if (param.length === 0) {
throw new TypeError(`param ${name} cannot be empty in request`)
}
return param as unknown as OutType
case 'number':
return param.toString() as OutType
default:
return new TypeError(`unrecognized type for parameter ${name}`) as OutType
}
}
This issue mostly concerns path parameters with default value during the client init. A more global change targeting these parameters might be a better option.
from scaleway-sdk-js.
In short, probably no way to fix at the moment. Will have to revisit the core issue.
from scaleway-sdk-js.
Related Issues (16)
- Improve locality type of an API
- help cannot connect SSH HOT 1
- Add error interceptors for network calls
- Upgrade to Node 18 and drop cross-fetch HOT 2
- Use Blob to manage files
- Add validation rules
- Consider changing most Interface definitions to Type HOT 2
- Consider exporting API types one by one instead of global * export
- Set most requests enums as optional
- List Scaleway configuration profiles
- Dependency Dashboard
- Scaleway sdk with remix run leads to TypeError: Invalid response object HOT 3
- Migrate from Lerna to Changesets
- Support for older Node versions HOT 3
- [TEM] Unable to set "reply to" address HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scaleway-sdk-js.