Coder Social home page Coder Social logo

Comments (2)

Vinzius avatar Vinzius commented on September 20, 2024

Even if we were to code a function having a different return type depending on the parameter (refactor of validatePathParam below), it would already break in the API methods as the output would be string | something-else and not just string. In our case, we would like an error only when the developer is using the lib, not before that.

export function validatePathParam<T extends string | number | undefined>(
  name: string,
  param: T,
): typeof param extends undefined ? TypeError : string {
  type OutType = typeof param extends undefined ? TypeError : string

  switch (typeof param) {
    case 'string':
      if (param.length === 0) {
        throw new TypeError(`param ${name} cannot be empty in request`)
      }

      return param as unknown as OutType
    case 'number':
      return param.toString() as OutType
    default:
      return new TypeError(`unrecognized type for parameter ${name}`) as OutType
  }
}

This issue mostly concerns path parameters with default value during the client init. A more global change targeting these parameters might be a better option.

from scaleway-sdk-js.

Vinzius avatar Vinzius commented on September 20, 2024

In short, probably no way to fix at the moment. Will have to revisit the core issue.

from scaleway-sdk-js.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.