[Bug] JSON error message when project has no readme about scaladex

[adpi2]

Thanks for the report. Would you like to submit a PR? :)

[mfirry]

Could this be solved by adding something like case HttpResponse(StatusCodes.NotFound, headers, entity, _) => in here?

[adpi2]

@mfirry Thanks for jumping into this. The issue is here:

scaladex/modules/webclient/src/main/scala/scaladex/client/Client.scala

Lines 43 to 52 in 13ec905

	val request = new Request(
	s"https://api.github.com/repos/$organization/$repository/readme",
	new RequestInit {
	headers = headersWithCreds.toJSDictionary
	}
	)
	fetch(request).toFuture
	.flatMap(res => res.text().toFuture)
	.foreach { res =>
	element.innerHTML = res

At the client side, we send a request to Github to get the readme but we don't check the status code.

[mfirry]

Ok so something along these lines would work for you?

    fetch(request).toFuture
      .flatMap { res =>
        if(res.status == 200) {
          res.text().toFuture
        } else {
          Future("No README found for this project, please check the repository")
        }

[adpi2]

Ok so something along these lines would work for you?

Yep it looks good