Coder Social home page Coder Social logo

Comments (11)

tmbo avatar tmbo commented on June 14, 2024

[author="tmbo", created="Sun, 9 Jun 2013 01:26:22 +0200"]

I am not sure what you mean. Download itself seems to be working. Do you mean that the changes you made on a read-only tracing are not included when downloading it?

from webknossos.

tmbo avatar tmbo commented on June 14, 2024

[author="", created="Sun, 9 Jun 2013 19:38:16 +0200"]

I think that is what he means.
I guess that is kind of expected because the nml is created server-side?
In my opinion it shouldn't be possible to change read only tracings at all (client-side)

Best,
Kevin

from webknossos.

tmbo avatar tmbo commented on June 14, 2024

[author="", created="Sun, 9 Jun 2013 19:48:01 +0200"]

It actually also reported an error page but I didn't save it.

from webknossos.

tmbo avatar tmbo commented on June 14, 2024

[author="tmbo", created="Sun, 9 Jun 2013 23:49:18 +0200"]

You are right Kevin, it's generated server side and because the changes are not propagated the nml doesn't change?
But I would keep it as a feature request in the backlog, as it is not to hard to solve.

Concerning the error page: A had a look into the log files and the error resulted due to the oxalis site moving to the new server.

from webknossos.

boergens avatar boergens commented on June 14, 2024

This needs to be fixed for review, at least in a roundabout way.
There are two question

What should trigger the warning

Minimum: Node creation
Minimum 2.0: Any skeleton change
Better: Also adding/removing skeletons
Better: Also volume tracing

What should be done on trigger

Minimum: alert()
Better: Asking: Do you want to duplicate this tracing. If so, equivalent action of down and upload of nml should be executed.

The "Better" points are not important

from webknossos.

georgwiese avatar georgwiese commented on June 14, 2024

Merged in #812, so this needs to be merged first

from webknossos.

georgwiese avatar georgwiese commented on June 14, 2024

Implemented the following:

  • All Skeleton / Volume tracing modifications are disabled on read-only tracings
  • Only exception is changing the active node / cell because this might be convenient (e.g. when reading comments)
  • When the user first tries to modify a tracing, an error message will be displayed

from webknossos.

georgwiese avatar georgwiese commented on June 14, 2024

@kevinbbb87 Please test this on branch OX-36. If you want, I can also deploy it for you, just notify me.

The read-only mode is not fully implemented yet (done in #812), but you can dynamically turn it on by executing:
oxalis.model.{skeletonTracing, volumeTracing}.restrictionHandler.restrictions.allowUpdate = false

from webknossos.

georgwiese avatar georgwiese commented on June 14, 2024

@kevinbbb87 Read-only URLs are now fully functional, so no need to mess with the JS ;)

To transform any tracing into a read-only tracing, insert /readOnly in front of the # symbol.
For example:
http://localhost:9000/annotations/Explorational/5613a0fa9036ef19018e6bd9#1537,842,512,0,-0.60,18
-->
http://localhost:9000/annotations/Explorational/5613a0fa9036ef19018e6bd9/readOnly#1537,842,512,0,-0.60,18

In #812, Tom Herold will build a UI that lets you retrieve this URL.

from webknossos.

boergens avatar boergens commented on June 14, 2024

Love it, works great for me!!

from webknossos.

georgwiese avatar georgwiese commented on June 14, 2024

PR #822

from webknossos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.