Comments (3)
Most of the above are implemented now, but wanted opinions on the remaining topics:
Challenge 5 has a "We Will:" section under the explanation that the other challenges do not have. Not sure we need to take any action here as it does work well for that challenge to sum that up beforehand.
This line is inconsistent between challenges, which is better? (It's also not in challenge 0 at all, should it be?)
- π©βπ» Rerun yarn deploy --reset whenever you want to deploy new contracts to the frontend, update your current contracts with changes, or re-deploy it to get a fresh contract address.
- π©βπ» Rerun yarn deploy whenever you want to deploy new contracts to the frontend (run yarn deploy --reset for a completely fresh deploy if you have made no contract changes).
[ ] Add a note in the blocknumber section about how to obtain that block number.
from se-2-challenges.
Challenge 5 has a "We Will:" section under the explanation that the other challenges do not have. Not sure we need to take any action here as it does work well for that challenge to sum that up beforehand.
I like the We Will: section in that case since its a great summary of what you will have to accomplish in the challenge. Challenge 5 use cases are a bit more special than previous challenges, so I feel is great to have it summarized in that way.
If we want to give it more visibility we could change "We will:" for something like "## Main Quests π " or something like that.
For the Challenges 0-4 we got this section in the Readme where we basically say all the stuff they'll have to accomplish, but in a less ordered way:
π The final deliverable is an app that allows ...
I feel is enough for those, but if we see it would be an improvement to show it in a list, we could migrate the Challenge 5 format to the rest of the challenges.
This line is inconsistent between challenges, which is better? (It's also not in challenge 0 at all, should it be?)
Even I think I wrote first variation myself, it seems like we suggesting our users to use always yarn deploy --reset
, so maybe we should use 2nd variation better:
π©βπ» Rerun
yarn deploy
whenever you want to deploy new contracts to the frontend (runyarn deploy --reset
for a completely fresh deploy if you have made no contract changes).
We could re-write it a bit if we see this other variation more clear:
π©βπ» Rerun
yarn deploy
whenever you want to deploy new contracts to the frontend. If you haven't made any contract changes, you can runyarn deploy --reset
for a completely fresh deploy.
In the Challenge 0, since users probably won't do any change to the contract, maybe that point is not that necesary. They're being introduced to SE-2 and all the stuff is new for them, so maybe is OK to know about yarn deploy --reset
from the Challenge 1 to not overwhelm them.
[ ] Add a note in the blocknumber section about how to obtain that block number.
I think it's a great idea to add a note/screenshot about how to obtain the specific blocknumber where their contracts were deployed.
from se-2-challenges.
If we want to give it more visibility we could change "We will:" for something like "## Main Quests π " or something like that.
Love it, done.
π©βπ» Rerun
yarn deploy
whenever you want to deploy new contracts to the frontend. If you haven't made any contract changes, you can runyarn deploy --reset
for a completely fresh deploy.
Normalized them all (Except 0) to this phrasing.
I think it's a great idea to add a note/screenshot about how to obtain the specific blocknumber where their contracts were deployed.
Done.
from se-2-challenges.
Related Issues (20)
- Migration to Wagmi V1 and Viem HOT 2
- Rewrite tests to viem HOT 1
- Challenge 0 - Checkpoint 4 deploy to Vercel build error with defaults HOT 3
- Challenge 0: use different package instead of react-json-view HOT 2
- Challenge 1 Checkpoint 1: Staking - "Stake Events" table data not loading HOT 4
- Backmerge event indexes after merge to se-2
- Challenge 4: Potential vulnerability with deposit function
- Challenge 4: Suggestions for UI/UX HOT 2
- challenge 6: Add toast notification when sending transactions
- challenge 6: update `backend-local` to use TS HOT 1
- challenge 6: update `backend-local` to use JSON file as db HOT 26
- Challenge 6: Require "New nΒΊ of signatures required" >0 when adding or removing signers HOT 3
- Update tests to supplement autograder HOT 5
- Install package too low HOT 2
- Challenge 0 - Workaround for users with IPFS blocked
- Add tests to multisig challenge
- Backmerge vercel deployment fix HOT 2
- Challenge 4: Broken telegram link? HOT 1
- Fix nfts image width
- Decide how to structure components folders HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from se-2-challenges.