Coder Social home page Coder Social logo

Comments (12)

ozbillwang avatar ozbillwang commented on July 2, 2024

a closed issue has been discussed before (#76)

Seems you insisted not to change. But the fact is, you should comment it out from your code, which default requiretty is problematic and breaks valid usage, confirmed by Redhat.

It is bug and fixed by redhat at March 2014.

* Mon Mar 10 2014 Daniel Kopecek <[email protected]> - 1.8.8-3
- remove bundled copy of zlib before compilation
- drop the requiretty Defaults setting from sudoers

from puppet-sudo.

saz avatar saz commented on July 2, 2024

I think, there should be some information in the docs, how to solve this problem, as it is easily solvable without any change in this module.

Maybe you'll got some time to create a pull request?

from puppet-sudo.

ozbillwang avatar ozbillwang commented on July 2, 2024

I have raised the pull request. #102

from puppet-sudo.

saz avatar saz commented on July 2, 2024

I'm good with the change, but this needs to be addressed in a better way:

  1. remove the line, including any comment. Do not comment them out (especially since the comment is wrong)
  2. remove the lines from all rhel files (5, 6 and 7)

I think this should solve the problem completely.

from puppet-sudo.

ozbillwang avatar ozbillwang commented on July 2, 2024

My latest pull request has been passed the validation. Waiting for the merge.

from puppet-sudo.

ozbillwang avatar ozbillwang commented on July 2, 2024

@saz , any updates for my pull request?

from puppet-sudo.

ozbillwang avatar ozbillwang commented on July 2, 2024

For anyone who stuck with this issue, and still waiting the pull request to be merged. Run below command in your Vagrantfile, it will bypass this issue.

config.vm.provision "shell", :inline => "echo 'Defaults:vagrant !requiretty' >>  /etc/sudoers.d/vagrant"

from puppet-sudo.

bkc1 avatar bkc1 commented on July 2, 2024

This requiretty/vagrant issue is a major pain. I am still a puppet novice but the saz-sudo module looks to be one of the better forge module options that has with Hiera capability. Could a true/false parameter be added in enable/disable(comment out) requiretty for Centos/RHEL flavors?

the following doesn't seem to work for me:
config.vm.provision "shell", :inline => "echo 'Defaults:vagrant !requiretty' >> /etc/sudoers.d/vagrant"

from puppet-sudo.

vindir avatar vindir commented on July 2, 2024

This is pretty easy to fix by adding an entry overriding the default. Something like the below makes it a non-issue when added to hieradata or done via the manifest itself.

sudo::configs:
    'requiretty':
        'content'   : "Defaults   !requiretty"
    'visiblepw':
        'content'   : "Defaults   visiblepw"

via the manifest it just becomes:

    class { 'sudo': }
    sudo::conf { 'requiretty':
      content  => "Defaults   !requiretty"
      priority => 10,
    }
    sudo::conf { 'visiblepw':
      content  => "Defaults   visiblepw"
      priority => 10,
    }

from puppet-sudo.

vindir avatar vindir commented on July 2, 2024

Also worth noting... if this issue is resolved, it should probably remove the !visiblepw default entries in all of the centos files as well since they are related configs.

from puppet-sudo.

ozbillwang avatar ozbillwang commented on July 2, 2024

@vindir
Good work, anyway, it is better solution than mine.

from puppet-sudo.

saz avatar saz commented on July 2, 2024

This should be fixed in the current master

from puppet-sudo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.