Comments (3)
I think this is the fix for the array-to-array comparison. It works for me as far as I can tell. In SpecificationDiff.java:
Original:
private static Property getResponseProperty(Operation operation) {
Map<String, Response> responses = operation.getResponses();
// temporary workaround for missing response messages
if (responses == null) return null;
Response response = responses.get("200");
return null == response ? null : response.getSchema();
}
Refactor to handle array:
private static Property getResponseProperty(Operation operation) {
Map<String, Response> responses = operation.getResponses();
// temporary workaround for missing response messages
if (responses == null) return null;
Response response = responses.get("200");
if(response != null && response.getSchema() instanceof ArrayProperty) {
ArrayProperty prop = (ArrayProperty)response.getSchema();
return prop.getItems();
}
return null == response ? null : response.getSchema();
}
from swagger-diff.
Hi ! This issue is a blocker for us ...
@Sayi Do you plan to merge #30 anytime soon ?
from swagger-diff.
@Sayi - Any plans to merge and release an update with this fix? I see this was merged in v1.2.2, however I do not see this difference in the HTML report. I will take another look at this and file a separate issue around HTML reporting if needed.
from swagger-diff.
Related Issues (20)
- Missing response diff HOT 1
- Missing return type diff
- Missing Dependencies(Maven) HOT 1
- Infinite recursion for comparing models
- Add support for vendor extensions HOT 2
- Could CLI allow override of CSS and title when generating HTML? HOT 1
- SLF4J runtime error for swagger-diff v1.2.1 HOT 2
- Swagger 3.0 support HOT 2
- Contract testing
- feature: Add diff of models
- Is this project still being maintained? HOT 2
- Html contains fixed reference to external css file
- no main manifest attribute, in swagger-diff-1.2.2.jar HOT 4
- Runtime incompatibility - NoSuchMethodError HOT 1
- Support for OpenAPI 3 HOT 1
- maybe a mistake
- Can we use YAML file instead of JSON file?
- Provide swagger-diff as standalone tool HOT 2
- Add support for compare by JsonNode HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swagger-diff.