Comments (1)
All inside 'song' dictionary:
album dictionary still has 'mbid' and '#text' keys artist dictionary still has 'url' and 'mbid' keys artist dictionary still has the old 'image' dictionary, along with the new proper 'images' dictionary
I left them in there on purpose. There is no reason to take them out. It's just more tests and more code and more dependency on them to be there in the first place. Just ignore them.
Also consider the 'recommendedAlbum' again - I know I'd use it, and it also gives me something to put for the detail text in the Queue with artists, which keeps the look consistent.
If you really think so, open separate issue.
Now is as good a time as any to add that if we'll ever use it.
I have several problems with this statement
Why is now a good as a time as any? Will there ever be a better time? You mean the need for having this "feature" will never be greater than it is now? Well that doesn't say very much about the feature since we don't really need it right now. I think there there will a certain optimal time to add this feature and we won't add it until then.
if we'll ever use it.
Feature creep is a very serious issue and it can bog us down, confused the user, dilute the functionality and purpose of the app, and depress me. Let's not add things to this app that we may never use.
from queue-api.
Related Issues (17)
- <null> is returned for items where there is no value HOT 7
- Check Last.fm username validity
- Don't remove "note" images HOT 1
- Song URL Improvements HOT 1
- "Recommended Album" on Artists
- "Message" on Queue items
- Handling multiple Queue items
- Shazam/Soundhound tagged songs in Recent Tracks HOT 2
- Caching HOT 4
- Slowness Caused by Link Getting After Posting to Queue
- Push Notification Notes: HOT 3
- Search Results HOT 4
- Server breaking every time a new property is sent HOT 2
- Change 'facebookId' in Queue item from user dictionary to 'fbId' HOT 1
- Return 'twitterUsername' with rest of user dictionary HOT 4
- Return empty or <null> usernames if user removes the name (changes it to "")
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from queue-api.