Split crashes into different issues about fabricplugin

[skaman]

I think we can only put a +1 here: https://twittercommunity.com/t/how-to-ungroup-non-fatal-exceptions-with-different-messages/59996/9
And hope twitter will do something about that.

[Justin-Credible]

Crashlytics is for tracking native crashes which are separate from JavaScript exceptions.

If you want to track your JavaScript exceptions you should use a service like http://LogEntries.com and log the JS errors from the window.on_error handler.

[jesusbotella]

I know Crashlytics is for native exceptions instead of the JS ones. But it gives more mobile specific information that is so useful. I have always used Sentry for that and I thought that the change would be worth it.

If no one has anything else to say, the issue can be closed. 👍

[skaman]

I found a way to workaround it (on iOS), i use recordError with a crc32 on the first line of the stack trace for the errore code. Maybe it's not perfect but for now (in my case) is enough.

Here is i did it on ionic with stacktrace.js

    .config(function($stateProvider, $urlRouterProvider, $provide) {
      $provide.decorator("$exceptionHandler", ['$delegate', function($delegate) {
        return function(exception, cause) {
            $delegate(exception, cause);

            var makeCRCTable = function(){
                var c;
                var crcTable = [];
                for(var n =0; n < 256; n++){
                    c = n;
                    for(var k =0; k < 8; k++){
                        c = ((c&1) ? (0xEDB88320 ^ (c >>> 1)) : (c >>> 1));
                    }
                    crcTable[n] = c;
                }
                return crcTable;
            }

            var crc32 = function(str) {
                var crcTable = window.crcTable || (window.crcTable = makeCRCTable());
                var crc = 0 ^ (-1);

                for (var i = 0; i < str.length; i++ ) {
                    crc = (crc >>> 8) ^ crcTable[(crc ^ str.charCodeAt(i)) & 0xFF];
                }

                return (crc ^ (-1)) >>> 0;
            };

            var message = exception.toString();
            var stacktrace = exception.stack.toLocaleString();
            window.fabric.Crashlytics.addLog("ERROR: " + message);
            window.fabric.Crashlytics.addLog("Stacktrace: " + stacktrace);
            window.fabric.Crashlytics.recordError(message, crc32(stacktrace.split('\n')[0]));
        };
      }]);

[wodka]

I added a pull request that will push the js stack trace to fabric - then all js errors will be grouped the right way (at least on android)