Coder Social home page Coder Social logo

Comments (10)

Justin-Credible avatar Justin-Credible commented on September 18, 2024

I've started working on this for my own project. Before I get too far, I'm just curious if you'd accept this as a pull request to your project, instead of me creating yet another plugin on npm.

My changes will be:

  • Add Framework for iOS
    • lib/ios/Crashlytics.framework
    • lib/ios/Fabric.framework
  • Add Framework for Android
    • lib/android/crashlytics.jar
    • lib/android/crashlytics-devtools.jar
    • lib/android/crashlytics_build.xml
    • lib/android/crashlytics_build_base.xml
  • Add build hooks to modify platform projects on plugin add
  • Add build hooks to remove platform project modifications on plugin remove

from fabricplugin.

sarriaroman avatar sarriaroman commented on September 18, 2024

Please feel free to send me your PR and please add yourself and contributor.

from fabricplugin.

Justin-Credible avatar Justin-Credible commented on September 18, 2024

I'm getting to close being done; I've got the automatic setup of the Fabric libraries for both iOS and Android:

https://github.com/Justin-Credible/FabricPlugin/commits/feature/auto-configure-fabric

For my own project, I ended up needing some extra logging events for Answers that did not exist yet, so I started adding them. This lead me to the .es6 files. Would you mind if I removed these and just use a plain JavaScript interface instead? While I am a fan of ES6, TypeScript, etc, it seems overkill in this case since the JavaScript methods simply delegate to cordova.exec(...). Otherwise contributors will need to setup babel to make changes to the JavaScript files. Edit: got the files to transpile with Babel 5.x.

from fabricplugin.

sarriaroman avatar sarriaroman commented on September 18, 2024

I was checking your repository, awesome job. Please create the Pull Request when you feel that the code is ready and add yourself as contributor!

from fabricplugin.

Justin-Credible avatar Justin-Credible commented on September 18, 2024

I ended up going forward and implementing all of the APIs for Answers, as well as added run-time tests and TypeScript definitions.

This turned out to be a rather large refactor touching all files.

I also bumped the version to 1.0.0 since all of the Crashlytics and Answers APIs are now present.

Let me know what you think.

from fabricplugin.

tomsun avatar tomsun commented on September 18, 2024

@Justin-Credible @sarriaroman curious; under which license is lib/ios/* distributed and from which url at fabric's servers do they originate?

from fabricplugin.

Justin-Credible avatar Justin-Credible commented on September 18, 2024

These iOS framework bundles were obtained from Cocoapods:

https://cocoapods.org/pods/Fabric
https://cocoapods.org/pods/Crashlytics

Podspec references:

https://github.com/CocoaPods/Specs/blob/master/Specs/Fabric/1.6.5/Fabric.podspec.json
https://github.com/CocoaPods/Specs/blob/master/Specs/Crashlytics/3.7.0/Crashlytics.podspec.json

Framework package ZIPs:

https://kit-downloads.fabric.io/cocoapods/fabric/1.6.5/fabric.zip
https://kit-downloads.fabric.io/cocoapods/crashlytics/3.7.0/crashlytics.zip

I've put in a pull request to put the above information into a readme file in the lib/ios directory.

from fabricplugin.

tomsun avatar tomsun commented on September 18, 2024

@Justin-Credible thanks!

from fabricplugin.

tomsun avatar tomsun commented on September 18, 2024

@Justin-Credible You linked to crashlytics 3.7.0, while f8ba9cf (which seems to be the latest update to lib/ios in master at the time of writing) refers to crashlytics 3.6.0.

Seems accurate otherwise: For peace of mind I verified with diff -r that the contents of lib/ios indeed matches what the following urls deliver to me ATM (unzipped) 👍
https://kit-downloads.fabric.io/cocoapods/fabric/1.6.5/fabric.zip
https://kit-downloads.fabric.io/cocoapods/crashlytics/3.6.0/crashlytics.zip

(Maybe it would be possible to get the files on demand from Fabric's servers using some Cordova hook, more along the lines of the Cocoapods workflow and the Maven workflow for the Android conterparts? https://github.com/sarriaroman/FabricPlugin/blob/master/hooks/lib/android-helper.js#L16 - That would eliminate the question whether or not the Fabric team is OK with redistribution and would keep this repo smaller (except one version is already in the Git history). Not sure exactly how to do it though...)

from fabricplugin.

Justin-Credible avatar Justin-Credible commented on September 18, 2024

@tomsun Ah! Thanks for catching that. I must have copy/pasted the wrong URL. I'll update my pull request.

from fabricplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.