Tests fail with with Adwaita after 3.30.1-1 about libnkutils

[sardemff7]

I have Adwaita icon theme 3.30.1 and it works as expected. Which version do you use exactly so I can try to reproduce?

[ortango]

3.32.0 as of now.

3.31.91 and 3.32.0 have been released since 3.30.1 on archlinux - and both releases produce the same failure.

[sardemff7]

Next time, please do not use “after release X” to say that, it’s unclear and doesn’t bring the key information.
I will try one of these two releases as soon as I can.

[ortango]

not that it matters, but that is what i posted to archlinux.org, where there was context.

i think that this commit is to blame for the change.

[sardemff7]

So the “context” is a link to a package that may disappear at any time, with the same information as here, except in a comment with a date.
Were you expecting me to dig into the Arch packages history to find the version of Adwaita you were using?
I try to be as quick as possible to fix “obvious” bugs, but I’m not paid for this, so I won’t the extra work to dig information that the reporter could find in a matter of seconds.

When reporting a bug, a rule of thumb is to provide all the context you can right inside the report. Reproducing a bug is very important and you cannot do that from one system to another without enough information.

As for the commit, it’s probably related, but I quickly checked the installed files and I still think it should pick the symbolic icon anyway, so moving the non-symbolic one shouldn’t have changed the result.

Anyway, with the Adwaita version to check I just need to test against it and see why the correct icon is not picked. I’ll have a fix for the next rofi release for sure.

[sardemff7]

After further investigation, it does come from this commit, but as a side effect.
Removing all pre-generated icons removed the directory section in index.theme, while the symbolic code does generate all of them from the SVGs. They should either fix the index.theme list or remove the generation for these legacy icons. Both will make older libnkutils works (as it skips tests if the icon to find is missing).

I’ve filed an issue on their Gitlab and I will try to find another icon to use in my tests.

[sardemff7]

Workaround added in 6164bac.

[ortango]

Were you expecting me to dig into the Arch packages history to find the version of Adwaita you were using?

sdardemff7: i did not post this BR.

*and thanks for giving this quick attention

[sardemff7]

@ortango it was more of a generic comment than one directed at you, sorry