Coder Social home page Coder Social logo

Comments (11)

styler00dollar avatar styler00dollar commented on July 17, 2024 2

Looks like the comments I replied to are gone. Stating this to avoid confusion. Maybe I should remove mine too..

from lama-cleaner.

Sanster avatar Sanster commented on July 17, 2024 1

MAT: https://github.com/Sanster/lama-cleaner/releases/tag/0.16.0

from lama-cleaner.

Sanster avatar Sanster commented on July 17, 2024

ZITS: https://github.com/Sanster/lama-cleaner/releases/tag/0.15.0

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

I feel like you don't properly use MAT. I used your MAT output image to draw over it with MAT again. Maybe your code is wrong.
182226870-b0ff5881-b505-4b18-9454-7eaafa533697_cleanup(5)

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

I created a few different images and I guess I left just one which I felt was the best one which I did in my limited testing. I just wanted to illustrate that I do not get the output you got with MAT. I just randomly drew a mask, not a square. I modded lama cleaner to have MAT which I used for this. It's still in a rough shape but functional. At the bottom I felt like trying to remove the lines since you showed color inconsistencies in the other images there. You did not even provide a mask, how am I supposed to guess what you did. My whole point was to show that MAT does not create such artifacts which you said it does, nothing else, and I think I archived that. You don't need to act rude.

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

This has nothing to do with the output quality of MAT and I can't be bothered to trace the pixels you inpainted. I just made a rough mask which is bigger and also masked a few minor details. My intention was not to perfectly replicate what you did. I won't repeat that again. If you can't contribute anything useful then just stop responding.

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

Who cares about the mask? I talk about the output quality of MAT. If you are looking for a fight, don't do it on Github and do it somewhere else. Github is a place for developers and not about arguing about stuff that is not even relevant. I guess I will just ignore further comments, if you can't seem to make any kind of productive comment. You could retry MAT, or whatever, instead you just pick on something that was never important.

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

What part of "I just randomly drew a mask, not a square. [...] At the bottom I felt like trying to remove the lines since you showed color inconsistencies" did you not get. Also, I am just pointing out that you somehow wrongly use MAT. I do not know how, but you did. Here, I did it again. Keep in mind that I added MAT into my code.
a
There are no such artefacts like in your picture.

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

I feel like you are trolling at this point. I took your mat as a base image to proof that the inpainted stuff does not look like your result and you did something wrong. It simply does not matter what image I use. Water looks like actual water and not this black/white whatever striped artifact. That was the only thing I wanted to show, nothing else. Absolutely nothing else. Why do you bring up stuff I never mentioned or cared about I wonder..

from lama-cleaner.

Sanster avatar Sanster commented on July 17, 2024

@styler00dollar I added the MAT model in this PR. Have you found any practical use where MAT works better than LaMa? In my tests, the MAT tends to produce strange results and does not perform well on high resolution, which I don't feel is very practical. Maybe there is something wrong with my code, will take some time to check it.

from lama-cleaner.

styler00dollar avatar styler00dollar commented on July 17, 2024

MAT is non-deterministic because of z = torch.randn(images_in.size(0), self.img_resolution), so you can generate a different image all the image, and since it is a transformer, you don't need to wait like in diffusion, which is what I liked about MAT. I didn't really do comparisons against lama. I mainly tested it on drawings and it did well there though. I only used it on 512x512 due to VRAM.

from lama-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.