SSA and generics (go1.18) about wastedassign

[migregal]

Hi, everyone!

Is there any movement about go1.19 release? Actually, i can't reproduce that problem with new version:

main.go

package main

import "fmt"

func wastedassignG[T ~int](hoge T) {
	var i int
	for {
		i = 5
	}

	fmt.Println(i)
}

func wastedassign(hoge int) {
	var i int
	for {
		i = 5
	}

	fmt.Println(i)
}

func main() {

}

And it gives me this output:

$ go vet -vettool=`which wastedassign` ./main/...                                                                                          
# <path>/main
main/main.go:8:3: assigned to i, but reassigned without using the value
main/main.go:17:3: assigned to i, but reassigned without using the value

Seems like it was fixed and golangci-lint can reenable wastedassign?

[sanposhiho]

Hm, thanks for informing. wait for a new version of SSA.

[ldez]

SSA has been updated and it seems to work inside golangci-lint.

[sanposhiho]

Thanks

[ldez]

in fact, the problem is still here

[ldez]

The code of the linter needs to be adapted to manage generics:

func wastedassignG[T ~int](hoge T) {
	var i int
	for {
		hoge = 5 // <- not detected KO
		// break
	}

	println(i)
	println(hoge)
	return
}

func wastedassign(hoge int) {
	var i int
	for {
		hoge = 5 // <- detected OK
		// break
	}

	println(i)
	println(hoge)
	return
}

[ldez]

go1.19 will come in about 2 weeks, it can be good if you can fix your linter before this release.