[Bug] Static and Class methods are added to the example request bodies about sanic-ext

[FlyinPancake]

@ahopkins thank you you're a legend

[FlyinPancake]

This issue cause my application not to start under Python 3.10.

[ahopkins]

Can you provide a minimal sample code snippet?

[ahopkins]

Maybe fixed by #98?

[FlyinPancake]

Okay so I checked and found some bad stuff with the new serialization

from dataclasses import dataclass
from pydantic import BaseModel
from sanic import Sanic, text
from sanic_ext import openapi

app = Sanic("test")


@dataclass
class Body:
    name: str

    @classmethod
    def ctor_method(cls):
        return cls("default")


@app.post("/")
@openapi.body({"application/json": Body})
async def test(request):
    return text("Test")

This gets us a doc entry like:

If I try to give a type even in ""-s the server refuses to start.

But since I posted this issue, I started using pydantic models for validation and simplicity. If I switch the dataclass for an equvivalent pydantic representation like:

class Body(BaseModel):
    name: str

It throws an error:

NameError: name 'unicode' is not defined

I don't know how I'm supposed to proceed, I'll revert to 22.3 for the meantime.

[ahopkins]

The classmethod will be a nice quick fix that I will get out and released. But unicode? 😕 Where is there Python 2 code?!

UPDATE: Looks like it it coming from standard lib. I will get this patch out and looks like it will resolve both issues.

diff --git a/sanic_ext/extensions/openapi/types.py b/sanic_ext/extensions/openapi/types.py
index 191132d..76a9c70 100644
--- a/sanic_ext/extensions/openapi/types.py
+++ b/sanic_ext/extensions/openapi/types.py
@@ -2,7 +2,7 @@ import json
 import uuid
 from datetime import date, datetime, time
 from enum import Enum
-from inspect import getmembers, isfunction
+from inspect import getmembers, isfunction, ismethod
 from typing import (
     Any,
     Dict,
@@ -312,7 +312,7 @@ def _properties(value: object) -> Dict:
         fields = {
             x: val
             for x, v in getmembers(value, _is_property)
-            if (val := _extract(v))
+            if (val := _extract(v)) and x in value.__dict__
         }
     except AttributeError:
         fields = {}
@@ -333,4 +333,4 @@ def _extract(item):
 
 
 def _is_property(item):
-    return not isfunction(item)
+    return not isfunction(item) and not ismethod(item)

[ahopkins]

Just pushed a 22.6.1