Coder Social home page Coder Social logo

Comments (7)

azimovMichael avatar azimovMichael commented on June 20, 2024 1

I will add a PR for this

from sanic-ext.

azimovMichael avatar azimovMichael commented on June 20, 2024 1

@prryplatypus Not sure I follow. We don't have a render_from_string function yet, do we?
It should be similar to the current render func, but instead of using environment.get_template it should use environment.from_string.

Once we'll have this function, I'm not sure why we need to use the html instead of returning HTTPResponse like the render function does

from sanic-ext.

prryplatypus avatar prryplatypus commented on June 20, 2024

Looking at this... I think all that's necessary is returning the render_template_string result with Sanic's html method? So basically creating a decorator that does just that?

from sanic import html

TEMPLATE = '''
<html>
<body>
  ...
</body>
</html>'''

rendered = render_from_string(TEMPLATE, context)

return html(rendered)

from sanic-ext.

ahopkins avatar ahopkins commented on June 20, 2024

@azimovMichael You are correct, we do not have that function yet. Your strategy is fine. html is just a convenience wrapper. You can just use HTTPResponse here as well.

The question that I have is does it make sense to have render and render_from_string?

Why not something like this:

def render(template_name="", template="", ...):
   if template_name and template:
       raise SomeException

render("my_template_name")  # backwards compat, keep this as first arg
render(template="<html>...")

from sanic-ext.

azimovMichael avatar azimovMichael commented on June 20, 2024

@ahopkins I wanted to provide a similar API to what Flask and Jinja itself provide, but sure we can do it in a single function.

from sanic-ext.

ahopkins avatar ahopkins commented on June 20, 2024

That makes sense. I personally don't like polluting the namespace so much 🤷‍♂️. I don't work on jinja much so this is helpful for me to know.

What if we provide both? I'd even go so far as to make it a keyword only argument on render.

from sanic-ext.

azimovMichael avatar azimovMichael commented on June 20, 2024

I'm actually totally fine with providing all in a single function.
Although Jijna does it in 2 functions, I actually prefer it to be in one.
Will do it with a kwarg-only arg.

from sanic-ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.