Coder Social home page Coder Social logo

Comments (6)

mperego avatar mperego commented on August 17, 2024

I agree on increasing the default workset size (this will help to mitigate the overhead of the Intrepid2 functions) .
However, I think it is best not to put workset size = -1 in all the tests (even for CUDA only builds) because then the case of multiple worksets per process is never tested.

from albany.

ibaned avatar ibaned commented on August 17, 2024

I think its early to base the default specifically on the GPU use case. I suspect Albany usage of GPU memory is nowhere near optimal yet. A while back I raised the default from 50 to 1000 for the PUMI Discretization; I propose we do the same for STK and see how things go from there. I am certain there are test problems with >1000 elements, so multiple worksets would still get exercised.

from albany.

ikalash avatar ikalash commented on August 17, 2024

I am fine with 1000. @ibaned , can you please make this change if there are no objections? I'll assign the issue to you. It will be interesting to see how the CUDA test results change with this increase in workset size.

from albany.

ibaned avatar ibaned commented on August 17, 2024

so my memory was off and PUMI was using ten thousand, but I changed it everywhere to one thousand. I'm closing this for now, lets reopen if it needs changing again or I broke something.

from albany.

agsalin avatar agsalin commented on August 17, 2024

Dan: I'm getting errors in my nightly build from this change. For Example:
examples/FELIX/FO_GIS/input_fo_gis_unstruct.xml

Error has to do with type -- not clear why you chose to free it from an .

p=0: *** Caught standard std::exception of type 'Teuchos::Exceptions::InvalidParameterType' :

Error! An attempt was made to access parameter "Workset Size" of type "int"
in the parameter (sub)list "Albany Parameters->Discretization"
using the incorrect type "Albany::AbstractMeshStruct::{unnamed type#1}"!

Throw number = 1

from albany.

mperego avatar mperego commented on August 17, 2024

Hi Andy, that has been fixed (see #47).

from albany.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.